Codex-generated pull request#21
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modifies the Arduino core header’s devicetree connector selection logic, narrowing how ZARD_CONNECTOR is determined.
Changes:
- Removed conditional
ZARD_CONNECTORfallbacks for several connector node labels (arduino_mkr_header,arduino_nano_header,pico_header,boosterpack_header).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #define ZARD_ARDUINO_HEADER_R3_DIGITAL_MAP_18 D12 | ||
| #define ZARD_ARDUINO_HEADER_R3_DIGITAL_MAP_19 D13 | ||
| #define ZARD_ARDUINO_HEADER_R3_DIGITAL_MAP_20 D14 | ||
| #define ZARD_ARDUINO_HEADER_R3_DIGITAL_MAP_21 D15 | ||
|
|
||
| #elif DT_NODE_EXISTS(DT_NODELABEL(arduino_mkr_header)) | ||
| #define ZARD_CONNECTOR arduino_mkr_header | ||
| #elif DT_NODE_EXISTS(DT_NODELABEL(arduino_nano_header)) | ||
| #define ZARD_CONNECTOR arduino_nano_header | ||
| #elif DT_NODE_EXISTS(DT_NODELABEL(pico_header)) | ||
| #define ZARD_CONNECTOR pico_header | ||
| #elif DT_NODE_EXISTS(DT_NODELABEL(boosterpack_header)) | ||
| #define ZARD_CONNECTOR boosterpack_header | ||
| #endif |
There was a problem hiding this comment.
The fallback selection of ZARD_CONNECTOR for arduino_mkr_header / arduino_nano_header / pico_header / boosterpack_header was removed. For targets where DT_NODELABEL(arduino_header) is absent but one of those connector node labels exists (and zephyr_user.digital_pin_gpios is also not set), this will leave ZARD_CONNECTOR undefined and enum digitalPins will not generate D0.. entries. Consider restoring the #elif DT_NODE_EXISTS(...) fallbacks, or adding an explicit #error/diagnostic when neither digital_pin_gpios nor a supported connector node is present to avoid silent build/runtime differences.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task