cores: restrict connector fallback to arduino-header-r3 only#22
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Restricts the Arduino connector-derived pin auto-generation path to only the Arduino Uno R3 header format, preventing unintended matches on arbitrary arduino_header connector nodes.
Changes:
- Gate
ZARD_CONNECTORauto-selection behindDT_NODE_HAS_COMPAT(..., arduino_header_r3). - Emit a compile-time
#errorwhen anarduino_headernode exists but is not R3-compatible (in the connector-fallback path).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
arduino_headernodes and narrow support to the Arduino Uno R3 connector format only, as required by the variant/support policy.Description
DT_NODE_HAS_COMPAT(DT_NODELABEL(arduino_header), arduino_header_r3)to enable connector-derived pin generation only for R3-style headers.#error "Only arduino-header-r3 connector is supported"when anarduino_headernode exists but is not R3-compatible to make the supported scope explicit.cores/arduino/Arduino.handdocumentation/variants.mdwas intentionally left unchanged.Testing
DT_NODE_HAS_COMPATguard and#errorare present, and that inspection succeeded.cores/arduino/Arduino.hwas modified anddocumentation/variants.mdremained untouched, and these checks succeeded.Codex Task