Codex-generated pull request#23
Closed
soburi wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Updates ArduinoCore-Zephyr devicetree handling to ignore disabled GPIO controllers when building global GPIO lookup tables, and aligns the configuration guide with the connector type the core actually supports.
Changes:
- Document that the board connector node label is expected to be
arduino_headerwithcompatible = "arduino-header-r3". - In Zephyr GPIO controller enumeration macros, treat disabled GPIO controllers as present-but-empty (nullptr device / 0 ngpios) to keep array indexing consistent and avoid using non-
okaynodes. - Filter
ZARD_ALL_GPIO_CTLRto include onlystatus = "okay"GPIO controllers.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| documentation/configuration-guide.md | Clarifies the expected Arduino connector label/compatible used by this core. |
| cores/arduino/zephyrCommon.cpp | Ensures disabled GPIO controllers contribute 0 ngpios (consistent with nullptr device entries) when deriving port/pin tables. |
| cores/arduino/Arduino.h | Filters GPIO controller node list to status = "okay" for connector-derived global pin offset calculations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Codex generated this pull request, but encountered an unexpected error after generation. This is a placeholder PR message.
Codex Task