Dac adc by soburi · Pull Request #28 · soburi/ArduinoCore-zephyr

soburi · 2026-03-01T02:00:13Z

No description provided.

Added a condition that the length of digital_pin_gpios is 0 or more. ------------------------------------------------------------------- Pick: arduino@d20ef628 Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

…sues The DIGITAL_PIN_EXISTS macro (used e.g. by LED_BUILTIN) was not working properly because the inline comments in devicetree_generated.h were confusing the preprocessor: one internal macro tried to create an unsigned constant by pasting a '*/' comment end marker with the 'U' character. Splitting that macro into two parts, so that the DT_REG_ADDR macro is invoked with an expanded argument, fixes the issue. ------------------------------------------------------------------- Pick: arduino@84651c2c Signed-off-by: Luca Burelli <l.burelli@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Add `DIGITAL_PIN_GPIOS_FIND_NODE` helper macro. ------------------------------------------------------------------- Pick: arduino@a60cd82a Co-Authored-by: Sebastian Romero <s.romero@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Silence a number of trivial compiler warnings in the Arduino core: - unused arguments - "constexpr const" ------------------------------------------------------------------ Pick: arduino@67251fb Signed-off-by: Luca Burelli <l.burelli@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Copilot

Pull request overview

This PR adds initial DAC support and introduces Arduino-style read/write resolution APIs for Zephyr-based Arduino core functions, aligning analog I/O behavior more closely with standard Arduino semantics.

Changes:

Add devicetree-driven DAC device/channel configuration and a DAC-specific analogWrite(dacPins, value) overload.
Add analogWriteResolution() / analogReadResolution() APIs (including C++ getters via a new header).
Apply resolution-based scaling to PWM analogWrite() and bit-shift mapping to analogRead() results.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 8 comments.

File	Description
`cores/arduino/zephyrCommon.cpp`	Adds DAC globals, DAC `analogWrite`, resolution APIs, and applies scaling/mapping logic for PWM/DAC writes and ADC reads.
`cores/arduino/overloads.h`	Introduces C++-only overload declarations (DAC `analogWrite`) and resolution getters.
`cores/arduino/Arduino.h`	Adds DAC driver include, DAC pin enum generation, and resolution API declarations; includes `overloads.h` for C++.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ababaec Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

69b644f Co-Authored-by: Kurt Eckhardt <kurte@rockisland.com> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Change analogReference declaration as a weak function. This is to accommodate the module configuration in the Arduino repository, but it does not have any adverse effects and is a way to coexist with the Zephyr repository, so we will include it. c8e82c1 Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-01T03:37:28Z

+#if (DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac))
+
+#define DAC_NODE       DT_PHANDLE(DT_PATH(zephyr_user), dac)
+#define DAC_RESOLUTION DT_PROP(DT_PATH(zephyr_user), dac_resolution)
+static const struct device *const dac_dev = DEVICE_DT_GET(DAC_NODE);
+
+#define DAC_CHANNEL_DEFINE(n, p, i)                                                                \
+	{                                                                                              \
+		.channel_id = DT_PROP_BY_IDX(n, p, i),                                                     \
+		.resolution = DAC_RESOLUTION,                                                              \
+		.buffered = true,                                                                          \
+	},
+
+static const struct dac_channel_cfg dac_ch_cfg[] = {
+	DT_FOREACH_PROP_ELEM(DT_PATH(zephyr_user), dac_channels, DAC_CHANNEL_DEFINE)};
+


The DAC devicetree guard only checks for the dac property, but this block also unconditionally uses dac_resolution and iterates dac_channels. Additionally, the DAC analogWrite(...) implementation later compiles under CONFIG_DAC even when this block is not compiled, which will break builds when CONFIG_DAC is enabled but the devicetree properties are missing. Please align the preprocessor guards so dac_dev/dac_ch_cfg and the DAC analogWrite(...) implementation are enabled/disabled together, and guard (or provide defaults for) dac_resolution/dac_channels usage explicitly.

Copilot · 2026-03-01T03:37:28Z

+#ifdef CONFIG_DAC
+
+void analogWrite(enum dacPins pinNumber, int value);
+


This header isn't self-contained: it declares APIs using enum dacPins without including the header that defines that enum (or forward-declaring it). Including overloads.h directly will fail to compile. Consider including <Arduino.h> here (consistent with other core headers) or adding an appropriate forward declaration.

134732a

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 6 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-03-01T04:03:39Z

+
+#endif


CONFIG_DAC currently errors out only when zephyr_user lacks dac_channels, but the implementation also depends on a zephyr_user.dac phandle and a zephyr_user.dac_resolution property. To avoid hard-to-diagnose compile errors and keep feature checks consistent with zephyrCommon.cpp, add compile-time checks for these required properties when CONFIG_DAC is enabled.

Suggested change

#endif

#if !DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac)

#error "CONFIG_DAC is enabled, but zephyr_user node lacks dac; disable CONFIG_DAC or define dac phandle"

#endif

#if !DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac_resolution)

#error "CONFIG_DAC is enabled, but zephyr_user node lacks dac_resolution; disable CONFIG_DAC or define dac_resolution"

#endif

#endif

Copilot · 2026-03-01T04:03:39Z

+#ifdef CONFIG_DAC
+
+#if (DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac))
+
+#define DAC_NODE       DT_PHANDLE(DT_PATH(zephyr_user), dac)
+#define DAC_RESOLUTION DT_PROP(DT_PATH(zephyr_user), dac_resolution)
+static const struct device *const dac_dev = DEVICE_DT_GET(DAC_NODE);
+
+#define DAC_CHANNEL_DEFINE(n, p, i)                                                                \
+	{                                                                                              \
+		.channel_id = DT_PROP_BY_IDX(n, p, i),                                                     \
+		.resolution = DAC_RESOLUTION,                                                              \
+		.buffered = true,                                                                          \
+	},
+
+static const struct dac_channel_cfg dac_ch_cfg[] = {
+	DT_FOREACH_PROP_ELEM(DT_PATH(zephyr_user), dac_channels, DAC_CHANNEL_DEFINE)};
+
+#endif


dac_dev / dac_ch_cfg are only defined when DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac) is true, but the DAC analogWrite() implementation is compiled under CONFIG_DAC unconditionally and uses those symbols. If CONFIG_DAC is enabled without a zephyr_user.dac phandle, this will fail to compile. Consider either removing this DT_NODE_HAS_PROP(..., dac) guard (and adding a compile-time #error when the required DT properties are missing) or extending the guard/feature checks so the implementation and declarations are consistent.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

ababaec Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

facchinm and others added 4 commits March 1, 2026 10:11

Copilot AI review requested due to automatic review settings March 1, 2026 02:00

Copilot started reviewing on behalf of soburi March 1, 2026 02:00 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

facchinm and others added 3 commits March 1, 2026 12:01

analogWrite: implement DAC pins

dd8c275

ababaec Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

cores: arduino: Implement analogReadResolution

80494d8

69b644f Co-Authored-by: Kurt Eckhardt <kurte@rockisland.com> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

soburi force-pushed the dac_adc branch from bd097e4 to 80a0bd6 Compare March 1, 2026 03:01

soburi requested a review from Copilot March 1, 2026 03:14

Copilot started reviewing on behalf of soburi March 1, 2026 03:14 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

Comment thread cores/arduino/overloads.h

Comment thread cores/arduino/zephyrCommon.cpp

Comment thread cores/arduino/zephyrCommon.cpp Outdated

Comment thread cores/arduino/zephyrCommon.cpp

Comment thread cores/arduino/zephyrCommon.cpp Outdated

soburi force-pushed the dac_adc branch from ccef6d9 to a97f723 Compare March 1, 2026 03:31

soburi requested a review from Copilot March 1, 2026 03:31

Copilot started reviewing on behalf of soburi March 1, 2026 03:32 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

facchinm and others added 5 commits March 1, 2026 12:46

make internal arduino_adc array static

02f8cf9

134732a

ZephyrCommon: allow boards without any ADC channel configured

aca45bd

Update cores/arduino/zephyrCommon.cpp

8f3d7d8

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Update cores/arduino/Arduino.h

08617df

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

x

cc5d3da

soburi force-pushed the dac_adc branch from 3ee7cde to cc5d3da Compare March 1, 2026 03:53

soburi requested a review from Copilot March 1, 2026 03:59

Copilot started reviewing on behalf of soburi March 1, 2026 04:00 View session

Copilot AI reviewed Mar 1, 2026

View reviewed changes

soburi and others added 3 commits March 1, 2026 13:09

Update cores/arduino/zephyrCommon.cpp

c03c3a1

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

analogWrite: implement DAC pins

84cf5bc

ababaec Co-Authored-by: Martino Facchin <m.facchin@arduino.cc> Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>

pulse

c6b2556

soburi force-pushed the cleanup_common branch from 83f9ac8 to a7727e5 Compare March 1, 2026 14:39

soburi closed this Apr 17, 2026

soburi deleted the dac_adc branch April 17, 2026 22:09

		#ifdef CONFIG_DAC

		void analogWrite(enum dacPins pinNumber, int value);

-#endif
+#if !DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac)
+#error "CONFIG_DAC is enabled, but zephyr_user node lacks dac; disable CONFIG_DAC or define dac phandle"
+#endif
+#if !DT_NODE_HAS_PROP(DT_PATH(zephyr_user), dac_resolution)
+#error "CONFIG_DAC is enabled, but zephyr_user node lacks dac_resolution; disable CONFIG_DAC or define dac_resolution"
+#endif
+#endif

Conversation

soburi commented Mar 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants