Add missing ADC header include to Arduino Uno R4 overlay#7
Merged
Conversation
Co-authored-by: soburi <458281+soburi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on configure by connector def PR
Add missing ADC header include to Arduino Uno R4 overlay
Feb 10, 2026
There was a problem hiding this comment.
Pull request overview
Adds the missing Zephyr ADC dt-bindings include to the Arduino Uno R4 variant overlay so ADC_ACQ_TIME_DEFAULT resolves during devicetree compilation.
Changes:
- Include
zephyr/dt-bindings/adc/adc.hin the Arduino Uno R4 overlay to provideADC_ACQ_TIME_DEFAULT.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Arduino Uno R4 overlay uses
ADC_ACQ_TIME_DEFAULTbut lacks the required header include, causing devicetree compilation to fail with an undefined macro error.Changes
#include <zephyr/dt-bindings/adc/adc.h>tovariants/arduino_uno_r4_r7fa4m1ab3cfm/arduino_uno_r4_r7fa4m1ab3cfm.overlayThis follows the pattern used in other variant overlays (arduino_nano_33_iot, rpi_pico, arduino_mkrzero) that configure ADC channels.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.