Skip to content

Commit 81f587e

Browse files
refactor(eio): fix typo in the cookie options
1 parent 5257ef9 commit 81f587e

2 files changed

Lines changed: 2 additions & 3 deletions

File tree

packages/engine.io/lib/server.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -213,8 +213,7 @@ export abstract class BaseServer extends EventEmitter {
213213
{
214214
name: "io",
215215
path: "/",
216-
// @ts-ignore
217-
httpOnly: opts.cookie.path !== false,
216+
httpOnly: true,
218217
sameSite: "lax",
219218
},
220219
opts.cookie,

packages/engine.io/test/server.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ describe("server", () => {
336336
expect(err).to.be(null);
337337
const sid = res.text.match(/"sid":"([^"]+)"/)[1];
338338
expect(res.headers["set-cookie"][0]).to.be(
339-
`io=${sid}; SameSite=Lax`,
339+
`io=${sid}; HttpOnly; SameSite=Lax`,
340340
);
341341
done();
342342
});

0 commit comments

Comments
 (0)