Skip to content

Commit ab4b34f

Browse files
ci: one workflow per workspace (2)
1 parent 4bb44f5 commit ab4b34f

5 files changed

Lines changed: 22 additions & 19 deletions

File tree

.github/workflows/ci-engine.io-client.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -61,10 +61,11 @@ jobs:
6161
- name: Run tests with Node.js native WebSocket
6262
run: npm run test:node-builtin-ws --workspace=engine.io-client
6363

64-
- name: Run tests in browser
65-
if: github.event_name == 'push'
66-
run: npm test --workspace=engine.io-client
67-
env:
68-
BROWSERS: 1
69-
SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
70-
SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
64+
# TODO: migrate tests from zuul to WebdriverIO
65+
# - name: Run tests in browser
66+
# if: github.event_name == 'push'
67+
# run: npm test --workspace=engine.io-client
68+
# env:
69+
# BROWSERS: 1
70+
# SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
71+
# SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}

.github/workflows/ci-engine.io-parser.yml

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -39,10 +39,11 @@ jobs:
3939
- name: Run tests
4040
run: npm test --workspace=engine.io-parser
4141

42-
- name: Run browser tests
43-
if: github.event_name == 'push'
44-
run: npm test --workspace=engine.io-parser
45-
env:
46-
BROWSERS: 1
47-
SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
48-
SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
42+
# TODO: migrate tests from zuul to WebdriverIO
43+
# - name: Run browser tests
44+
# if: github.event_name == 'push'
45+
# run: npm test --workspace=engine.io-parser
46+
# env:
47+
# BROWSERS: 1
48+
# SAUCE_USERNAME: ${{ secrets.SAUCE_USERNAME }}
49+
# SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}

.github/workflows/ci-socket.io-client.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
- name: Compile dependencies
5151
run: |
5252
npm run compile \
53+
--workspace=engine.io-parser \
5354
--workspace=engine.io-client \
5455
--workspace=socket.io-parser
5556
@@ -59,6 +60,7 @@ jobs:
5960
- name: Compile dev dependencies
6061
run: |
6162
npm run compile \
63+
--workspace=engine.io \
6264
--workspace=socket.io
6365
6466
- name: Run tests

.github/workflows/ci-socket.io-component-emitter.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
name: CI (socket.io-component-emitter)
1+
name: CI (@socket.io/component-emitter)
22

33
on:
44
push:
@@ -33,8 +33,5 @@ jobs:
3333
- name: Install dependencies
3434
run: npm ci
3535

36-
- name: Compile package
37-
run: npm run compile --workspace=socket.io-component-emitter
38-
3936
- name: Run tests
40-
run: npm test --workspace=@socket.io/component-emitter
37+
run: npm test --workspace=socket.io-component-emitter

.github/workflows/ci-socket.io.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
- name: Compile dependencies
5151
run: |
5252
npm run compile \
53+
--workspace=engine.io-parser \
5354
--workspace=engine.io \
5455
--workspace=socket.io-adapter \
5556
--workspace=socket.io-parser
@@ -60,6 +61,7 @@ jobs:
6061
- name: Compile dev dependencies
6162
run: |
6263
npm run compile \
64+
--workspace=engine.io-client \
6365
--workspace=socket.io-client
6466
6567
- name: Run tests

0 commit comments

Comments
 (0)