Remove obsolete restart exception.

Assisted-By: devx/3236e566-7538-432e-a30a-2bdf37265ed4

Author: samuel-williams-shopify

lib/async/container/error.rb

@@ -31,16 +31,6 @@ def initialize
 			end
 		end
 
-		# Similar to {Interrupt}, but represents `SIGHUP`.
-		class Restart < SignalException
-			SIGHUP = Signal.list["HUP"]
-			
-			# Create a new restart error.
-			def initialize
-				super(SIGHUP)
-			end
-		end
-		
 		# Represents the error which occured when a container failed to start up correctly.
 		class SetupError < Error
 			# Create a new setup error.

lib/async/container/forked.rb

@@ -104,13 +104,8 @@ def self.fork(**options)
 						# Fork from `Thread.new` so the child does not inherit the parent fiber scheduler or the current caller's fiber stack. Only this short-lived thread is copied into the child process:
 						::Thread.new do
 							::Process.fork do
-								# We use `Thread.current.raise(...)` so that exceptions are filtered through `Thread.handle_interrupt` correctly.
-								Signal.trap(:INT){::Thread.current.raise(Interrupt)}
-								Signal.trap(:TERM){::Thread.current.raise(Interrupt)}  # Same as SIGINT.
-								Signal.trap(:HUP){::Thread.current.raise(Restart)}
-								
-								# Reset `SignalException` delivery because CRuby inherits the `Thread.handle_interrupt` mask stack across `Thread.new`. Async deliberately masks signal exceptions, and the signal traps above should be delivered promptly:
-								::Thread.handle_interrupt(SignalException => :immediate) do
+								# Reset interrupt masking - `Exception` is a fast path:
+								::Thread.handle_interrupt(Exception => :immediate) do
 									yield Instance.for(process)
 								rescue Interrupt
 									# Graceful exit.

lib/async/container/threaded.rb

@@ -211,11 +211,6 @@ def kill!
 					@thread.kill
 				end
 
-				# Raise {Restart} in the child thread.
-				def restart!
-					@thread.raise(Restart)
-				end
-				
 				# Wait for the thread to exit and return he exit status.
 				# @asynchronous This method may block.
 				#

releases.md

@@ -4,6 +4,7 @@
 
   - Use `async-signals` to coordinate controller signal traps while queueing signal events through the controller event loop.
   - Require `async-signals` v0.6 so controller signal handling is implicit only when running on the main thread without an existing fiber scheduler, and loading `async-container` installs graceful default `SIGINT`/`SIGTERM` handling.
+  - Remove the obsolete `Async::Container::Restart` signal exception.
 
 ## v0.37.0
 

test/async/container/policy.rb

@@ -254,14 +254,21 @@ def child_exit(container, child, status, name:, key:, **options)
 			end.new
 
 			container = Async::Container.best_container_class.new(policy: stop_policy)
+			trigger = IO.pipe
 
 			3.times do |i|
 				container.spawn(name: "worker-#{i}") do |instance|
 					instance.ready!
+					
+					trigger.first.gets
 					exit(1)
 				end
 			end
 
+			container.wait_until_ready
+			
+			trigger.last.puts("exit")
+			
 			container.wait
 
 			expect(stop_policy.stop_count).to be == 1