Honor configured graceful timeout in controller#65
Merged
Conversation
samuel-williams-shopify
force-pushed
the
honor-controller-graceful-timeout
branch
2 times, most recently
from
ed46460 to
4d56327
Compare
Assisted-By: devx/46718d0f-efc9-4196-a7c6-272fcf2ba5d0
samuel-williams-shopify
force-pushed
the
honor-controller-graceful-timeout
branch
from
4d56327 to
8f627e7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Async::Container::Controller#initializetoGRACEFUL_TIMEOUTinstead of literaltrue.ASYNC_CONTAINER_GRACEFUL_TIMEOUTcontrols the controller default in a fresh process.This complements socketry/async-service@3b2c234, which made
Async::Service::Controller#stophonor inherited@graceful_stop. Without this lower-layer default, async-service still inherits literaltrueunless callers explicitly passgraceful_stop:.Tests
bundle exec sus test/async/container/controller.rbbundle exec sus