Make policy stop test deterministic#70
Merged
Merged
Conversation
Assisted-By: devx/904563b8-dbee-48b0-9726-f036df3ed96d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
"can stop the container from child_exit"test was racy. All three workers calledexit(1)immediately, so multiplechild_exitcallbacks could fire beforecontainer.stoptook effect. The policy guards withunless container.stopping?, but that's a check-then-act race — several children can each observestopping? == falseand incrementstop_count, making thestop_count == 1assertion flaky.Fix
Only the first worker exits, and only after all workers are ready (coordinated via a pipe). The others
sleep. This guarantees exactly onechild_exitdrives the stop, sostop_countis deterministically1.Test-only, no library change. Verified stable across repeated runs.