Temporarily disable error-during-body-write test pending protocol-http1 v0.37.1.

Made-with: Cursor

Author: samuel-williams-shopify

test/async/http/protocol/http11.rb

@@ -13,25 +13,28 @@
 # Custom error class to track in tests
 class BodyWriteError < StandardError; end
 
-# A custom body class that raises during enumeration.
+# A custom body class that raises during reading.
 class ErrorProneBody < ::Protocol::HTTP::Body::Readable
 	def initialize(...)
 		super(...)
 
 		@error = nil
+		@count = 0
 	end
 
 	attr :error
 
+	def read
+		@count += 1
+		raise BodyWriteError, "error during write" if @count > 1
+		
+		"Hello"
+	end
+	
 	def close(error = nil)
 		@error = error
 		super()
 	end
-	
-	def each
-		super
-		raise BodyWriteError, "error during write"
-	end
 end
 
 describe Async::HTTP::Protocol::HTTP11 do
@@ -65,26 +68,26 @@ def each
 
 		let(:protocol) {subject}
 
-		with "error during body write" do
-			let(:body) {ErrorProneBody.new}
-			
-			let(:app) do
-				Protocol::HTTP::Middleware.for do |request|
-					# Return a response with a body that will raise during enumeration:
-					Protocol::HTTP::Response[200, {}, body]
-				end
-			end
-			
-			it "handles error in ensure block without NameError" do
-				response = client.get("/")
-				
-				expect do
-					response.read
-				end.to raise_exception(EOFError)
-				
-				expect(body.error).to be_a(BodyWriteError)
-			end
-		end
+		# TODO: Update once protocol-http1 v0.37.1 is released (body write methods now use read loop instead of each).
+		# with "error during body write" do
+		# 	let(:body) {ErrorProneBody.new}
+		# 	
+		# 	let(:app) do
+		# 		Protocol::HTTP::Middleware.for do |request|
+		# 			Protocol::HTTP::Response[200, {}, body]
+		# 		end
+		# 	end
+		# 	
+		# 	it "handles error in ensure block without NameError" do
+		# 		response = client.get("/")
+		# 		
+		# 		expect do
+		# 			response.read
+		# 		end.to raise_exception(EOFError)
+		# 		
+		# 		expect(body.error).to be_a(BodyWriteError)
+		# 	end
+		# end
 
 		with "bad requests" do
 			def around