Tidy up tests.

Author: samuel-williams-shopify

lib/async/deadline.rb

@@ -7,12 +7,12 @@
 
 # @namespace
 module Async
-	# Manages a countdown timer for timeout operations.
-	# Provides precise deadline tracking for compound operations to prevent timeout accumulation where multiple operations could exceed user timeouts.
+	# Represents a deadline timeout with decrementing remaining time.
+	# Includes an efficient representation for zero (non-blocking) timeouts.
 	# @public Since *Async v2.31*.
 	class Deadline
 		# Singleton module for immediate timeouts (zero or negative).
-		# Avoids object allocation for performance.
+		# Avoids object allocation for fast path (non-blocking) timeouts.
 		module Zero
 			# Check if the deadline has expired.
 			# @returns [Boolean] Always returns true since zero timeouts are immediately expired.

test/async/clock.rb

@@ -31,6 +31,41 @@
 		expect(clock.total).to be_within(2 * Sus::Fixtures::Time::QUANTUM).of(0.02)
 	end
 
+	with "#start" do
+		it "handles multiple start/stop cycles" do
+			3.times do
+				clock.start!
+				# Calling start! again should be idempotent - no time should be added
+				first_total = clock.total
+				clock.start!
+				second_total = clock.total
+				
+				# The total should not jump significantly just from calling start! again
+				expect(second_total - first_total).to be < 0.001
+				clock.stop!
+			end
+			
+			expect(clock.total).to be >= 0
+		end
+	end
+	
+	with "#stop" do
+		it "handles stop without start" do
+			result = clock.stop!
+			expect(result).to be == 0
+			expect(clock.total).to be == 0
+		end
+
+		it "handles multiple stops" do
+			clock.start!
+			first_stop = clock.stop!
+			second_stop = clock.stop!
+			
+			expect(first_stop).to be == second_stop
+			expect(clock.total).to be == first_stop
+		end
+	end
+
 	with "#total" do
 		with "initial duration" do
 			let(:clock) {subject.new(1.5)}
@@ -48,6 +83,21 @@
 			sleep(0.0001)
 			expect(clock.total).to be >= total
 		end
+
+		it "preserves total during start/stop cycles" do
+			# First cycle
+			clock.start!
+			sleep(0.001)
+			first_total = clock.stop!
+			
+			# Second cycle
+			clock.start!
+			sleep(0.001)
+			second_total = clock.stop!
+			
+			expect(second_total).to be > first_total
+			expect(clock.total).to be == second_total
+		end
 	end
 
 	with ".start" do
@@ -77,7 +127,7 @@
 		end
 	end
 
-	with "monotonicity" do
+	with ".now" do
 		it "produces monotonic timestamps" do
 			first = Async::Clock.now
 			second = Async::Clock.now
@@ -95,62 +145,4 @@
 			expect(duration).to be >= 0
 		end
 	end
-	
-	with "edge cases" do
-		it "handles multiple start/stop cycles" do
-			3.times do
-				clock.start!
-				# Calling start! again should not change the start time
-				original_start = clock.instance_variable_get(:@started)
-				clock.start!
-				expect(clock.instance_variable_get(:@started)).to be == original_start
-				clock.stop!
-			end
-			
-			expect(clock.total).to be >= 0
-		end
-		
-		it "handles stop without start" do
-			result = clock.stop!
-			expect(result).to be == 0
-			expect(clock.total).to be == 0
-		end
-		
-		it "handles multiple stops" do
-			clock.start!
-			first_stop = clock.stop!
-			second_stop = clock.stop!
-			
-			expect(first_stop).to be == second_stop
-			expect(clock.total).to be == first_stop
-		end
-		
-		it "preserves total during start/stop cycles" do
-			# First cycle
-			clock.start!
-			sleep(0.001)
-			first_total = clock.stop!
-			
-			# Second cycle  
-			clock.start!
-			sleep(0.001)
-			second_total = clock.stop!
-			
-			expect(second_total).to be > first_total
-			expect(clock.total).to be == second_total
-		end
-		
-		it "includes running time in total" do
-			base_total = clock.total
-			expect(base_total).to be == 0
-			
-			clock.start!
-			sleep(0.001)
-			running_total = clock.total
-			
-			expect(running_total).to be > base_total
-			expect(clock.instance_variable_get(:@started)).not.to be_nil
-		end
-	end
-	
 end