100% test coverage.

Author: samuel-williams-shopify

fixtures/async/a_queue.rb

@@ -130,6 +130,19 @@ module Async
 				expect(queue.wait).to be == :item
 			end
 		end
+
+		with "#close" do
+			it "signals waiting tasks when closed" do
+				waiting_task = reactor.async do
+					queue.dequeue
+				end
+
+				queue.close
+
+				waiting_task.wait
+				expect(waiting_task).to be(:finished?)
+			end
+		end
 
 		with "an empty queue" do
 			it "is expected to be empty" do
@@ -175,6 +188,42 @@ module Async
 				expect(count).to be == repeats
 			end
 		end
+
+		with "a closed queue" do
+			before do
+				queue.close
+			end
+
+			it "prevents push after close" do
+				expect{queue.push(:item)}.to raise_exception(Async::Queue::ClosedError)
+			end
+
+			it "prevents enqueue after close" do
+				expect{queue.enqueue(:item)}.to raise_exception(Async::Queue::ClosedError)
+			end
+
+			it "prevents << after close" do
+				expect{queue << :item}.to raise_exception(Async::Queue::ClosedError)
+			end
+
+			it "returns nil from dequeue when closed and empty" do
+				expect(queue.dequeue).to be_nil
+			end
+
+			it "returns nil from pop when closed and empty" do
+				expect(queue.pop).to be_nil
+			end
+
+			it "signals waiting tasks when closed" do
+				waiting_task = reactor.async do
+					queue.dequeue
+				end
+
+				# Already closed, so just check if the task finishes:
+				waiting_task.wait
+				expect(waiting_task).to be(:finished?)
+			end
+		end
 
 		it_behaves_like Async::ChainableAsync do
 			def before

lib/async/queue.rb

@@ -55,6 +55,10 @@ def empty?
 
 		# Add an item to the queue.
 		def push(item)
+			if @closed
+				raise ClosedError, "Cannot push items to a closed queue."
+			end
+			
 			@items << item
 
 			@available.signal unless self.empty?
@@ -153,7 +157,7 @@ def close
 
 		# @returns [Boolean] Whether trying to enqueue an item would block.
 		def limited?
-			@items.size >= @limit
+			!@closed && @items.size >= @limit
 		end
 
 		# Add an item to the queue.

test/async/limited_queue.rb

@@ -45,7 +45,7 @@
 		end
 
 		10.times do
-			item = queue.dequeue
+			queue.dequeue
 			total_dequeued += 1
 
 			expect(total_resumed).to be == total_dequeued
@@ -83,5 +83,21 @@ def before
 			end
 		end
 	end
+
+	with "#close" do
+		it "signals tasks waiting to enqueue items when closed" do
+			queue.enqueue(:item1)
+
+			# This task will block as the queue is full:
+			waiting_task = reactor.async do
+				queue.enqueue(:item2)
+			end
+
+			queue.close
+
+			waiting_task.wait
+			expect(waiting_task).to be(:finished?)
+		end
+	end
 end