Correct comment about when blocking_operation_wait() was released

[XrXr]

The hook is not in the v2.19.0 tag.
c317990 shows that it was first added with v2.21.0.

[ioquatix]

Thanks for correcting this!

[ioquatix]

FYI, this feature is highly experimental, I believe we need a better implementation of the worker pool - probably a C extension so we avoid re-acquiring the GVL in a thread.

[XrXr]

If this is highly experimental, maybe it should be opt-in instead of opt-out (by not upgrading)? There's been 2 class of crashes related to this hook, and I suspect there's more yet to be discoverd.

• https://bugs.ruby-lang.org/issues/21198
• https://bugs.ruby-lang.org/issues/21180

Moving a nogvl call off to a different thread is inherently tricky to get right.

[ioquatix]

Thanks for your suggestion and the links to the issues.

I was under the impression that it is already opt-in: https://github.com/socketry/async/blob/main/lib/async/scheduler.rb#L28-L30

Ah, I see, there was a previous release where it was on by default: 41a0c92

But now it is already off by default (opt-in only).