Show compound units in elapsed time display. (#87)

Author: wtn

lib/console/clock.rb

@@ -16,21 +16,28 @@ def self.formatted_duration(duration)
 				return format("%.2fs", duration)
 			end
 
-			duration /= 60.0
+			minutes = duration / 60.0
 
-			if duration < 60.0
-				return "#{duration.floor}m"
+			if minutes < 60.0
+				seconds = duration % 60
+				return format("%dm%02ds", minutes, seconds)
 			end
 
-			duration /= 60.0
+			hours = minutes / 60.0
 
-			if duration < 24.0
-				return "#{duration.floor}h"
+			if hours < 24.0
+				minutes = minutes % 60
+				return format("%dh%02dm", hours, minutes)
 			end
 
-			duration /= 24.0
+			days = hours / 24.0
+			
+			if days < 100.0
+				hours = hours % 24
+				return format("%dd%02dh", days, hours)
+			end
 
-			return "#{duration.floor}d"
+			return format("%dd", days)
 		end
 
 		# @returns [Time] The current monotonic time.

releases.md

@@ -1,5 +1,9 @@
 # Releases
 
+## Unreleased
+
+  - Show compound units in elapsed time display.
+
 ## v1.36.0
 
   - Add a `size_limit` to `Console::Format::Safe` (default 16KiB) which rebuilds oversized records field-by-field, keeping as many top-level fields as fit within the limit.

test/console/clock.rb

@@ -16,30 +16,40 @@
 			expect(subject.formatted_duration(2)).to be == "2.00s"
 			expect(subject.formatted_duration(10)).to be == "10.00s"
 			expect(subject.formatted_duration(59)).to be == "59.00s"
+			expect(subject.formatted_duration(59.999)).to be == "60.00s"
 		end
 
 		it "can format minutes" do
-			expect(subject.formatted_duration(60)).to be == "1m"
-			expect(subject.formatted_duration(61)).to be == "1m"
-			expect(subject.formatted_duration(120)).to be == "2m"
-			expect(subject.formatted_duration(600)).to be == "10m"
-			expect(subject.formatted_duration(3599)).to be == "59m"
+			expect(subject.formatted_duration(60)).to be == "1m00s"
+			expect(subject.formatted_duration(61)).to be == "1m01s"
+			expect(subject.formatted_duration(61.999)).to be == "1m01s"
+			expect(subject.formatted_duration(120)).to be == "2m00s"
+			expect(subject.formatted_duration(600)).to be == "10m00s"
+			expect(subject.formatted_duration(3599.999)).to be == "59m59s"
+			expect(subject.formatted_duration(3599)).to be == "59m59s"
 		end
 
 		it "can format hours" do
-			expect(subject.formatted_duration(3600)).to be == "1h"
-			expect(subject.formatted_duration(3601)).to be == "1h"
-			expect(subject.formatted_duration(7200)).to be == "2h"
-			expect(subject.formatted_duration(36000)).to be == "10h"
-			expect(subject.formatted_duration(86399)).to be == "23h"
+			expect(subject.formatted_duration(3600)).to be == "1h00m"
+			expect(subject.formatted_duration(3601)).to be == "1h00m"
+			expect(subject.formatted_duration(7200)).to be == "2h00m"
+			expect(subject.formatted_duration(36000)).to be == "10h00m"
+			expect(subject.formatted_duration(86399.999)).to be == "23h59m"
+			expect(subject.formatted_duration(86399)).to be == "23h59m"
 		end
 
 		it "can format days" do
-			expect(subject.formatted_duration(86400)).to be == "1d"
-			expect(subject.formatted_duration(86401)).to be == "1d"
-			expect(subject.formatted_duration(172800)).to be == "2d"
-			expect(subject.formatted_duration(604799)).to be == "6d"
-			expect(subject.formatted_duration(864000)).to be == "10d"
+			expect(subject.formatted_duration(86400)).to be == "1d00h"
+			expect(subject.formatted_duration(86401)).to be == "1d00h"
+			expect(subject.formatted_duration(172800)).to be == "2d00h"
+			expect(subject.formatted_duration(604799)).to be == "6d23h"
+			expect(subject.formatted_duration(864000)).to be == "10d00h"
+		end
+		
+		it "can format many days" do
+			expect(subject.formatted_duration(8640000 - 1)).to be == "99d23h"
+			expect(subject.formatted_duration(8640000)).to be == "100d"
+			expect(subject.formatted_duration(86400000)).to be == "1000d"
 		end
 	end