Fix workflow: use PATH override, build ext per Ruby, test worker_pool

Co-authored-by: Cursor <cursoragent@cursor.com>

Author: samuel-williams-shopify

.github/workflows/test-ruby-gc-bug.yaml

@@ -24,102 +24,83 @@ jobs:
         ref: bug/blocking-operation-gc
         path: ruby-src
 
-    - name: Configure Ruby (shared flags for all cases)
-      working-directory: ruby-src
-      run: |
-        ./autogen.sh
-        ./configure \
-          --prefix=$HOME/.rubies/ruby-caseA \
-          --enable-shared \
-          --disable-install-doc \
-          --enable-yjit \
-          cppflags="-DENABLE_PATH_CHECK=0"
-
     # ── CASE_A: NULL, full O3 (expected to crash) ─────────────────────────
     - name: Patch to CASE_A — operation = NULL
       working-directory: ruby-src
       run: |
+        ./autogen.sh
+        ./configure --prefix=$HOME/.rubies/ruby-caseA --enable-shared --disable-install-doc cppflags="-DENABLE_PATH_CHECK=0"
         sed -i 's/rb_fiber_scheduler_blocking_operation_t \*operation = get_blocking_operation(blocking_operation);/rb_fiber_scheduler_blocking_operation_t *operation = NULL;/' scheduler.c
         grep -n "operation = NULL" scheduler.c
 
     - name: Build + install CASE_A
       working-directory: ruby-src
       run: make -j$(nproc) && make install
 
-    - name: Set up io-event for CASE_A
-      run: |
-        $HOME/.rubies/ruby-caseA/bin/gem install bundler --no-document
-        $HOME/.rubies/ruby-caseA/bin/bundle install
-        $HOME/.rubies/ruby-caseA/bin/bundle exec ruby -e "require 'io/event'; puts IO::Event::Selector.default"
-        $HOME/.rubies/ruby-caseA/bin/bundle exec rake build 2>/dev/null || \
-          $HOME/.rubies/ruby-caseA/bin/bundle exec ruby ext/extconf.rb && make -C ext
-
-    - name: Build io-event extension for CASE_A
-      run: |
-        $HOME/.rubies/ruby-caseA/bin/ruby ext/io/event/extconf.rb
-        make -C ext
-
-    - name: Run tcp_socket test CASE_A (expect crash)
-      id: test_caseA
-      run: |
-        $HOME/.rubies/ruby-caseA/bin/bundle exec ruby test/tcp_socket.rb 2>&1 | tail -5 || true
-        echo "status=$?" >> $GITHUB_OUTPUT
-      continue-on-error: true
-
     # ── CASE_C: NULL + O0 on function ─────────────────────────────────────
-    - name: Patch to CASE_C — add __attribute__((optimize("O0"))) + NULL
+    - name: Patch to CASE_C — CASE_A + __attribute__((optimize("O0")))
       working-directory: ruby-src
       run: |
         git checkout scheduler.c
         sed -i 's/rb_fiber_scheduler_blocking_operation_t \*operation = get_blocking_operation(blocking_operation);/rb_fiber_scheduler_blocking_operation_t *operation = NULL;/' scheduler.c
         sed -i 's/^VALUE rb_fiber_scheduler_blocking_operation_wait(/__attribute__((optimize("O0"))) VALUE rb_fiber_scheduler_blocking_operation_wait(/' scheduler.c
         grep -n 'optimize\|operation = NULL' scheduler.c | head -5
-        ./configure \
-          --prefix=$HOME/.rubies/ruby-caseC \
-          --enable-shared \
-          --disable-install-doc \
-          --enable-yjit \
-          cppflags="-DENABLE_PATH_CHECK=0"
+        ./configure --prefix=$HOME/.rubies/ruby-caseC --enable-shared --disable-install-doc cppflags="-DENABLE_PATH_CHECK=0"
 
     - name: Build + install CASE_C
       working-directory: ruby-src
       run: make -j$(nproc) && make install
 
-    - name: Build io-event extension for CASE_C
-      run: |
-        $HOME/.rubies/ruby-caseC/bin/ruby ext/io/event/extconf.rb
-        make -C ext
-
-    - name: Run tcp_socket test CASE_C (does O0 fix the crash?)
-      id: test_caseC
-      run: |
-        $HOME/.rubies/ruby-caseC/bin/bundle exec ruby test/tcp_socket.rb 2>&1 | tail -5 || true
-        echo "status=$?" >> $GITHUB_OUTPUT
-      continue-on-error: true
-
-    # ── Compare disassembly ────────────────────────────────────────────────
-    - name: Disassemble CASE_A vs CASE_C (key function only)
+    # ── Disassemble both ───────────────────────────────────────────────────
+    - name: Disassemble CASE_A and CASE_C
       run: |
         echo "=== CASE_A (O3, operation=NULL) ==="
         objdump -d --no-show-raw-insn -M intel $HOME/.rubies/ruby-caseA/lib/libruby.so.4.1 \
           | awk '/^[0-9a-f]+ <rb_fiber_scheduler_blocking_operation_wait>:/{found=1} found{print} found && /^$/{exit}' \
           > /tmp/case_a.asm
-        wc -l /tmp/case_a.asm
+        cat /tmp/case_a.asm
+        echo ""
         echo "=== CASE_C (O0 on fn, operation=NULL) ==="
         objdump -d --no-show-raw-insn -M intel $HOME/.rubies/ruby-caseC/lib/libruby.so.4.1 \
           | awk '/^[0-9a-f]+ <rb_fiber_scheduler_blocking_operation_wait>:/{found=1} found{print} found && /^$/{exit}' \
           > /tmp/case_c.asm
-        wc -l /tmp/case_c.asm
+        cat /tmp/case_c.asm
 
-    - name: Upload disassembly
+    - name: Upload disassembly artifacts
       uses: actions/upload-artifact@v4
       if: always()
       with:
         name: disassembly-A-vs-C
         path: /tmp/case_*.asm
 
+    # ── Build io-event extension for each Ruby and test ───────────────────
+    - name: Build io-event for CASE_A
+      run: |
+        export PATH=$HOME/.rubies/ruby-caseA/bin:$PATH
+        gem install bundler --no-document
+        bundle install
+        cd ext/io/event && ruby extconf.rb && make
+
+    - name: Run worker_pool test CASE_A (expect crash)
+      id: test_caseA
+      run: |
+        export PATH=$HOME/.rubies/ruby-caseA/bin:$PATH
+        (bundle exec ruby test/io/event/worker_pool.rb 2>&1 | tail -10; echo "exit:$?") || true
+      continue-on-error: true
+
+    - name: Build io-event for CASE_C
+      run: |
+        export PATH=$HOME/.rubies/ruby-caseC/bin:$PATH
+        cd ext/io/event && ruby extconf.rb && make
+
+    - name: Run worker_pool test CASE_C (does O0 fix the crash?)
+      id: test_caseC
+      run: |
+        export PATH=$HOME/.rubies/ruby-caseC/bin:$PATH
+        (bundle exec ruby test/io/event/worker_pool.rb 2>&1 | tail -10; echo "exit:$?") || true
+      continue-on-error: true
+
     - name: Summary
+      if: always()
       run: |
-        echo "CASE_A (O3, NULL): status ${{ steps.test_caseA.outputs.status }}"
-        echo "CASE_C (O0, NULL): status ${{ steps.test_caseC.outputs.status }}"
-        echo "If CASE_A crashes and CASE_C passes -> optimization-level is the cause"
+        echo "If CASE_A crashes and CASE_C passes -> optimization level is the cause"