Benchmark EPoll and URing side-by-side in CI#168
Merged
Conversation
Add a selector matrix (EPoll / URing) to the benchmark workflow so both backends run in the same CI pass and can be compared directly. Also install liburing-dev so the URing backend is actually compiled, and bump checkout to actions/checkout@v4. Co-authored-by: Cursor <cursoragent@cursor.com>
samuel-williams-shopify
force-pushed
the
benchmark-baseline
branch
2 times, most recently
from
5669bab to
4b9a046
Compare
samuel-williams-shopify
added a commit
that referenced
this pull request
May 10, 2026
Add a selector matrix (EPoll / URing) to the benchmark workflow so both backends run in the same CI pass and can be compared directly. Also install `liburing-dev` so the URing backend is actually compiled, and bump checkout to actions/checkout@v4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The benchmark workflow never installed
liburing-dev, so every benchmark run silently used epoll. There was no way to compare the two backends without a separate branch.What
selectormatrix dimension (EPoll/URing) so both backends run in the same CI pass.IO_EVENT_SELECTOR: ${{matrix.selector}}on the benchmark step —IO::Event::Selector.defaultalready reads this env var.liburing-devso the URing backend is compiled and available.actions/checkout@v2→@v4while here.How to read the results
Each job is named
EPoll on ubuntu (head)/URing on ubuntu (head)— compare theRequests/seclines between the two jobs for each server scenario (event.rb,loop.rb,thread.rb, etc.).This branch is on unmodified
main, so the numbers serve as a clean baseline before any wakeup / SINGLE_ISSUER changes.Made with Cursor