Ignore/close body for no entity body status codes.#23
Merged
Conversation
ioquatix
force-pushed
the
handle-no-entity-body-status-codes
branch
from
75dd378 to
35ab964
Compare
ioquatix
force-pushed
the
handle-no-entity-body-status-codes
branch
from
35ab964 to
33589e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rack applications sometimes incorrectly return non-empty bodies for status codes which should not have an entity body. In those cases, we close and ignore the body (and warn if appropriate).
If we don't do this, we may incorrectly send a response body causing the remote end to give up, resulting in EPIPE: socketry/falcon#289.
Types of Changes
Contribution