Skip to content

Fix handling of rewind after reading all input.#24

Merged
ioquatix merged 2 commits intomainfrom
rewind-after-reading
May 10, 2025
Merged

Fix handling of rewind after reading all input.#24
ioquatix merged 2 commits intomainfrom
rewind-after-reading

Conversation

@ioquatix
Copy link
Copy Markdown
Member

@ioquatix ioquatix commented May 9, 2025

Fixes an issue where #rewind no longer works if the entire body is read, causing an implicit close.

Fixes #24.

Types of Changes

  • Bug fix.

Contribution

@ioquatix ioquatix force-pushed the rewind-after-reading branch from d484ed1 to a9205c1 Compare May 9, 2025 02:30
@ioquatix
Copy link
Copy Markdown
Member Author

ioquatix commented May 9, 2025

Without this PR:

> curl -X POST -d "This is test data" http://localhost:9292
First read: "This is test data"

Second read: ""⏎                                                                                                                                                 

With this PR:

> curl -X POST -d "This is test data" http://localhost:9292
First read: "This is test data"

Second read: "This is test data"⏎   

@ioquatix ioquatix linked an issue May 10, 2025 that may be closed by this pull request
@ioquatix ioquatix merged commit 220222f into main May 10, 2025
72 of 80 checks passed
@ioquatix ioquatix deleted the rewind-after-reading branch May 10, 2025 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Falcon App Server: Request Body Cannot Be Rewound for Multiple Reads

1 participant