Skip to content

[Scenes] Fix runtime warnings, and consistent behavior between python and xml#179

Merged
epernod merged 4 commits into
sofa-framework:masterfrom
fredroy:remove_warnings_scenes
May 2, 2025
Merged

[Scenes] Fix runtime warnings, and consistent behavior between python and xml#179
epernod merged 4 commits into
sofa-framework:masterfrom
fredroy:remove_warnings_scenes

Conversation

@fredroy
Copy link
Copy Markdown
Contributor

@fredroy fredroy commented Apr 23, 2025

Note that there are warnings about Mass in the same node, because there are as many AdaptiveFFandMass as there are tools.

 Warning:  [Node(InstrumentCombined)] Trying to add a BaseMass ('unnamed' [AdaptiveBeamForceFieldAndMass] 0x55e365ac6680) into the Node '/InstrumentCombined', whereas it already contains one ('CatheterForceField' [AdaptiveBeamForceFieldAndMass] 0x55e36579c810). Only one BaseMass is permitted in a Node. The previous BaseMass is replaced and the behavior is undefined.
Warning:  [Node(InstrumentCombined)] Trying to add a BaseMass ('unnamed' [AdaptiveBeamForceFieldAndMass] 0x55e36593ff40) into the Node '/InstrumentCombined', whereas it already contains one ('GuideForceField' [AdaptiveBeamForceFieldAndMass] 0x55e365ac6680). Only one BaseMass is permitted in a Node. The previous BaseMass is replaced and the behavior is undefined.

I dont know how to fix it 🤔

@fredroy fredroy added pr: clean pr: status to review To notify reviewers to review this pull-request labels Apr 23, 2025
@fredroy fredroy force-pushed the remove_warnings_scenes branch from e2f234f to c120349 Compare April 23, 2025 02:05
@alxbilger
Copy link
Copy Markdown
Contributor

You can create a Node for each AdaptiveBeamForceFieldAndMass. As is, I suspect that the mass is not taken into account properly. Only the last one contributes to the mass. But the force field part of each AdaptiveBeamForceFieldAndMass should be ok.

@fredroy fredroy force-pushed the remove_warnings_scenes branch 3 times, most recently from 7bb26b4 to de1641e Compare April 27, 2025 22:26
@fredroy fredroy force-pushed the remove_warnings_scenes branch from de1641e to 5713300 Compare April 29, 2025 05:57
@fredroy fredroy force-pushed the remove_warnings_scenes branch from b2c02e2 to b0bc4eb Compare April 29, 2025 23:37
@fredroy fredroy force-pushed the remove_warnings_scenes branch from b0bc4eb to 3cdf9bc Compare April 29, 2025 23:39
@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels May 2, 2025
Copy link
Copy Markdown
Contributor

@epernod epernod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue #182 has been created to investigate

@epernod epernod merged commit 029a09b into sofa-framework:master May 2, 2025
4 checks passed
@fredroy fredroy deleted the remove_warnings_scenes branch May 2, 2025 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants