MultiAdaptiveBeamMapping: Fix collision sampling#204
Merged
Conversation
fredroy
added
enhancement
fredroy
force-pushed
the
multimapp_maxcollis
branch
from
0802f1f to
0b63b47
Compare
epernod
added
pr: status ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
Title says all, it was still based on the mechanical sampling (aka number of beams)
example of the 3instrument_collis.scn, customized on the tip of the catheter
master
length of 10, 10 collision points (9 edges)
length of 10, 100 collision points (99 edges)
We can see it is the same
This PR:
length of 10, 10 collision points (9 edges)
length of 10, 100 collision points (99 edges)
Like #203, the regressions need to be regenerated 😿