Skip to content

Commit 0719834

Browse files
committed
Remove polymorphic inheritance for the trampoline class to avoid pointer shift when casting into a SOFA base class in MSVC
1 parent 8f2b4d0 commit 0719834

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Component.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ class TrampolineBase
3232
{
3333
public:
3434
explicit TrampolineBase(sofa::core::objectmodel::BaseComponent* self);
35-
virtual ~TrampolineBase();
35+
~TrampolineBase();
3636

3737
void trampoline_handleEvent(sofa::core::objectmodel::Event* event);
3838
std::string trampoline_getClassName() const;
@@ -76,7 +76,6 @@ class Component_Trampoline : public Component, public TrampolineBase
7676
SOFA_CLASS(Component_Trampoline, Component);
7777

7878
Component_Trampoline();
79-
~Component_Trampoline() override = default;
8079

8180
void init() override;
8281
void reinit() override;

bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Controller.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ class Controller_Trampoline : public Controller, public TrampolineBase
4444
SOFA_CLASS(Controller_Trampoline, Controller);
4545

4646
Controller_Trampoline();
47-
~Controller_Trampoline() override = default;
4847

4948
void init() override;
5049
void reinit() override;

0 commit comments

Comments
 (0)