Acquire gil for the full scope of the lifetime returned matrix (#609)

bakpaul · web-flow · commit 23b5efca44c2 · 2026-04-23T16:53:11.000+09:00
diff --git a/bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_ForceField.cpp b/bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_ForceField.cpp
@@ -121,7 +121,6 @@ namespace sofapython3
     template<class TDOFType>
     py::object ForceField_Trampoline<TDOFType>::_addKToMatrix(const MechanicalParams* mparams, int nIndices, int nDofs)
     {
-        PythonEnvironment::gil acquire;
 
         py::dict mp = py::dict("time"_a=getContext()->getTime(),
                                "mFactor"_a=mparams->mFactor(),
@@ -136,6 +135,8 @@ namespace sofapython3
     template<class TDOFType>
     void ForceField_Trampoline<TDOFType>::addKToMatrix(const MechanicalParams* mparams, const MultiMatrixAccessor* dfId)
     {
+        PythonEnvironment::gil acquire;
+        
         MultiMatrixAccessor::MatrixRef mref = dfId->getMatrix(this->mstate);
         sofa::linearalgebra::BaseMatrix* mat = mref.matrix;
 

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,6 @@ namespace sofapython3`
`121`	`121`	`template<class TDOFType>`
`122`	`122`	`py::object ForceField_Trampoline<TDOFType>::_addKToMatrix(const MechanicalParams* mparams, int nIndices, int nDofs)`
`123`	`123`	`{`
`124`		`- PythonEnvironment::gil acquire;`
`125`	`124`
`126`	`125`	`py::dict mp = py::dict("time"_a=getContext()->getTime(),`
`127`	`126`	`"mFactor"_a=mparams->mFactor(),`
`@@ -136,6 +135,8 @@ namespace sofapython3`
`136`	`135`	`template<class TDOFType>`
`137`	`136`	`void ForceField_Trampoline<TDOFType>::addKToMatrix(const MechanicalParams* mparams, const MultiMatrixAccessor* dfId)`
`138`	`137`	`{`
	`138`	`+ PythonEnvironment::gil acquire;`
	`139`	`+`
`139`	`140`	`MultiMatrixAccessor::MatrixRef mref = dfId->getMatrix(this->mstate);`
`140`	`141`	`sofa::linearalgebra::BaseMatrix* mat = mref.matrix;`
`141`	`142`