fix warning about pair copy creation in for-loop

fredroy · fredroy · commit fcf5f3076240 · 2026-06-09T08:07:32.000+09:00
diff --git a/Sofa/framework/Simulation/Core/src/sofa/simulation/task/WorkerThread.cpp b/Sofa/framework/Simulation/Core/src/sofa/simulation/task/WorkerThread.cpp
@@ -245,15 +245,15 @@ bool WorkerThread::addTask(Task *task)
 
 bool WorkerThread::stealTask(Task **task)
 {
-    for (const auto it : m_taskScheduler->_threads)
+    for (const auto& [id, otherThread] : m_taskScheduler->_threads)
     {
         // if this is the main thread continue
-        if (std::this_thread::get_id() == it.first)
+        if (std::this_thread::get_id() == id)
         {
             continue;
         }
 
-        WorkerThread *otherThread = it.second;
+        //WorkerThread *otherThread = it.second;
         {
             simulation::ScopedLock lock(otherThread->m_taskMutex);
             if (!otherThread->m_tasks.empty())

Original file line number	Diff line number	Diff line change
`@@ -245,15 +245,15 @@ bool WorkerThread::addTask(Task *task)`
`245`	`245`
`246`	`246`	`bool WorkerThread::stealTask(Task **task)`
`247`	`247`	`{`
`248`		`- for (const auto it : m_taskScheduler->_threads)`
	`248`	`+ for (const auto& [id, otherThread] : m_taskScheduler->_threads)`
`249`	`249`	`{`
`250`	`250`	`// if this is the main thread continue`
`251`		`- if (std::this_thread::get_id() == it.first)`
	`251`	`+ if (std::this_thread::get_id() == id)`
`252`	`252`	`{`
`253`	`253`	`continue;`
`254`	`254`	`}`
`255`	`255`
`256`		`- WorkerThread *otherThread = it.second;`
	`256`	`+ //WorkerThread *otherThread = it.second;`
`257`	`257`	`{`
`258`	`258`	`simulation::ScopedLock lock(otherThread->m_taskMutex);`
`259`	`259`	`if (!otherThread->m_tasks.empty())`