Skip to content

Add types to PurgatoryPropertyAccessor#132

Merged
HypeMC merged 1 commit intosofascore:2.xfrom
Brajk19:purgatory-property-accessor-types
Dec 17, 2025
Merged

Add types to PurgatoryPropertyAccessor#132
HypeMC merged 1 commit intosofascore:2.xfrom
Brajk19:purgatory-property-accessor-types

Conversation

@Brajk19
Copy link
Copy Markdown
Member

@Brajk19 Brajk19 commented Dec 17, 2025

since version 2 will not support SF5, we can add types

@Brajk19 Brajk19 requested a review from HypeMC December 17, 2025 08:33
@Brajk19 Brajk19 self-assigned this Dec 17, 2025
Comment thread src/RouteProvider/PropertyAccess/PurgatoryPropertyAccessor.php
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 17, 2025

Codecov Report

❌ Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.33%. Comparing base (d8a2471) to head (670863c).
⚠️ Report is 1 commits behind head on 2.x.

Files with missing lines Patch % Lines
...vider/PropertyAccess/PurgatoryPropertyAccessor.php 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                2.x     #132   +/-   ##
=========================================
  Coverage     97.33%   97.33%           
  Complexity      509      509           
=========================================
  Files            69       69           
  Lines          1426     1426           
=========================================
  Hits           1388     1388           
  Misses           38       38           
Flag Coverage Δ
8.1 97.33% <50.00%> (ø)
8.2 97.26% <50.00%> (ø)
8.3 97.05% <50.00%> (ø)
8.4 97.05% <50.00%> (ø)
8.5 97.05% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@HypeMC HypeMC force-pushed the purgatory-property-accessor-types branch from 1d9e0f8 to 670863c Compare December 17, 2025 08:35
@HypeMC HypeMC changed the title Add types to PurgatoryPropertyAccessor Add types to PurgatoryPropertyAccessor Dec 17, 2025
@HypeMC HypeMC merged commit f8f01de into sofascore:2.x Dec 17, 2025
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants