Skip to content

Fix if with nullable inverse subscriptions#98

Merged
HypeMC merged 2 commits intosofascore:1.xfrom
Brajk19:nullable-inverse
Apr 14, 2025
Merged

Fix if with nullable inverse subscriptions#98
HypeMC merged 2 commits intosofascore:1.xfrom
Brajk19:nullable-inverse

Conversation

@Brajk19
Copy link
Copy Markdown
Member

@Brajk19 Brajk19 commented Apr 11, 2025

fixes #97

@Brajk19 Brajk19 requested a review from HypeMC April 11, 2025 20:07
@Brajk19 Brajk19 self-assigned this Apr 11, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.95%. Comparing base (a14ef9b) to head (ab0ed81).
Report is 1 commits behind head on 1.x.

Additional details and impacted files
@@            Coverage Diff            @@
##                1.x      #98   +/-   ##
=========================================
  Coverage     96.94%   96.95%           
  Complexity      487      487           
=========================================
  Files            62       62           
  Lines          1442     1444    +2     
=========================================
+ Hits           1398     1400    +2     
  Misses           44       44           
Flag Coverage Δ
8.1 96.95% <100.00%> (+<0.01%) ⬆️
8.2 96.87% <100.00%> (+<0.01%) ⬆️
8.3 96.87% <100.00%> (+<0.01%) ⬆️
8.4 96.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread tests/Functional/TestApplication/Controller/PersonController.php
Comment thread src/Cache/PropertyResolver/AssociationResolver.php
@HypeMC HypeMC merged commit b26c4cb into sofascore:1.x Apr 14, 2025
40 checks passed
@HypeMC HypeMC changed the title Fix for nullable inverse subscriptions Fix if with nullable inverse subscriptions Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Nullable relations are not checked when creating inverse subscriptions

2 participants