feat: provide catch-all function to process dep rule#246
Open
sdurnov wants to merge 4 commits intosoftarc-consulting:mainfrom
Open
feat: provide catch-all function to process dep rule#246sdurnov wants to merge 4 commits intosoftarc-consulting:mainfrom
sdurnov wants to merge 4 commits intosoftarc-consulting:mainfrom
Conversation
|
Author
|
fixed stupid AI stuff and added some tests |
Collaborator
|
@sdurnov thanks. Plan to review it this week. |
Author
Hi there, any quick thoughts on this maybe? |
rainerhahnekamp
requested changes
Apr 7, 2026
Collaborator
rainerhahnekamp
left a comment
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Good work, just a few minor comments where I think an AI should be able to handle them properly 👍
|
Author
|
Hey, @rainerhahnekamp, hope it's fine now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here's a very drafty draft, mostly vibe coded.
rn I'm writing sheriff config for my project, and checking if it even works (seems to be working).
After I make sure, I can add few tests if necessary and fix any issues
#245