Skip to content

Unifying RTParserBuilder and CTParserBuilder #555

@ratmice

Description

@ratmice

This writing down some thoughts so they don't get lost.

in PR #550 we had when trying to test the change, briefly toyed around with adding a callback mechanism which
returned a result and all the parameters needed to build an RTParserBuilder, this was dropped from the patch pretty
quickly in favor of just having a #[cfg(test)] method on the builder, as it was fairly beyond the scope of the patch.

The impression that the implementation gave me personally was that it required a lot of arguments to build a RTParserBuilder.
One way that that could be alleviated is just building an RTParserBuilder, and passing it directly to the callback.

On top of that though this involves linker/parser interaction with the token map, so it isn't clear to me that just reducing the number of parameters is going to get things to a mergeable quality.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions