Mrejdak/remove old native biometry#325
Draft
mrejdak wants to merge 1162 commits into
Draft
Conversation
…/66425-part-3 Part 3 - Thread delegateEmail through unapprove/retract/submit report actions
…/66425-part-2b [No QA] Refactor editTaskAssignee to use options object
…1-Top-Categories-Add-a-limit-filter-to-search fix: Reports - Limit filter is reapplied after resetting filters
…bs/actions/Policy/Policy.ts - Fix leaveWorkspace leftover: replace deprecatedSessionAccountID with currentUserAccountID for pendingChatMembers - Refactor createWorkspaceFromIOUPayment: add currentUserAccountID as explicit parameter instead of using deprecatedSessionAccountID for ownerAccountID - Update BaseKYCWall.tsx caller to pass currentUserAccountID from useCurrentUserPersonalDetails - Add tests verifying explicit parameters are used instead of Onyx session Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…hn-extract-empty-state [No QA] refactor: Extract LHNEmptyState from LHNOptionsList
…rt-85409-jsenyitko-event-tracking [No QA] Add IDs to tooltips for tracking
…report-screen-6d decompose ReportScreen 6d: extract navigate-away handler
- Remove isCondensed from GBR/RBR action badges to use default badge size - Remove badge container from pin icon, render as bare icon at 16px - Shrink pencil (draft) icon from 20px to 16px to match pin Co-authored-by: Aimane Chnaif <aimane-chnaif@users.noreply.github.com>
…or-policy-to-use-useonyx-15 [No QA] Refactor createDraftWorkspace to use newGenerateDefaultWorkspaceName
…tWorkspaceDisplay Co-authored-by: Jayesh Mangwani <jayeshmangwani@users.noreply.github.com>
fix: default emoji doesn't render
…poser-sidepanel-focus Fix: Focus jumps to Concierge Anywhere (SidePanel) when switching chats in the Inbox
…-add-cards [Payment due @ShridharGoel] Fix infinite spinner add cards
…oney-request [No QA]: Move updateMoneyRequest functions to IOU/UpdateMoneyRequest.ts
…tor-MoneyRequestConfirmationList-extract-side-effect-components perf: decompose MoneyRequestConfirmationList
…low-UI-refactor-r2 Manual expense flow UI refactor r2
…rrorVisibility Show custom range error message near Save button instead of below calendars
…report-screen-7 decompose ReportScreen 7: extract rendering orchestrators
…i-trie-build Refactored Emoji Trie build logic to improve perf
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…to pregenerate-thumbnails-for-the-confirm-screen
…e-thumbnails-for-the-confirm-screen feat: Add thumbnail support for receipts and improve image handling
Add Gusto beta constant
…erge-can-do [No QA] Create What-Concierge-Can-Do.md
…ortWorkspaceDisplay Fix Create Report row showing wrong workspace name when moving expenses
…changed-user [Internal QA] Add missed cleanup after login as another user
…raForAttachments fix: use in-app VisionCamera for chat attachments with proper permission handling
…vigation-description [No QA] docs: Update Help menu description for in-product Help page
…date-range-filter docs: document date range filter syntax in search operators article
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
This pull request removes the old native biometrics, which used
nobleandexpo-secure-storeFixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectiontoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari