feat: add disable dismiss on scrim press to native scrim#26
Closed
lklima wants to merge 4 commits into
Closed
Conversation
…e on native scrim tap
… non-dismissible scrim behavior
… dismissal behavior
patrickmichalik
left a comment
Collaborator
There was a problem hiding this comment.
Hello! Thanks for the PR. Rather than adding a new prop, I’d make scrim-tap dismissal respect the closed detent’s programmatic flag: When the closed detent is programmatic, the scrim should ignore taps. The fact that it’s currently otherwise is entirely an oversight.
Contributor
Author
|
Ok, I'll close this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an option to disable dismiss on native scrim press.
Motivation
Sometimes we need the modal to be dissmissed only by an internal action like a confirm/next button, currently to do this, we need to create a custom scrim, this pr enables this feature in the built-in scrim along with the use of
detents={[programmatic(0), 'content']}