Skip to content

feat: add disable dismiss on scrim press to native scrim#26

Closed
lklima wants to merge 4 commits into
software-mansion-labs:mainfrom
lklima:main
Closed

feat: add disable dismiss on scrim press to native scrim#26
lklima wants to merge 4 commits into
software-mansion-labs:mainfrom
lklima:main

Conversation

@lklima

@lklima lklima commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Summary

Add an option to disable dismiss on native scrim press.

Motivation

Sometimes we need the modal to be dissmissed only by an internal action like a confirm/next button, currently to do this, we need to create a custom scrim, this pr enables this feature in the built-in scrim along with the use of
detents={[programmatic(0), 'content']}

@patrickmichalik patrickmichalik left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the PR. Rather than adding a new prop, I’d make scrim-tap dismissal respect the closed detent’s programmatic flag: When the closed detent is programmatic, the scrim should ignore taps. The fact that it’s currently otherwise is entirely an oversight.

@lklima

lklima commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

Ok, I'll close this

@lklima lklima closed this Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants