Skip to content

chore: Remove externalNames from unplugin #2504

@aleksanderkatan

Description

@aleksanderkatan

Blocked by #2502, #2505
externalNames make transformed function code contain redundancy, since it can always be retrieved via Object.keys from externals.

  const metadata = `{
    v: ${FORMAT_VERSION},
    name: ${name ? `"${name}"` : 'undefined'},
    ast: ${embedJSON(ast)}, // <- redundancy here
    externals: () => ({${ast.externalNames
      .map((e) => (e === 'this' ? '"this": this' : e))
      .join(', ')}}),
  }`;

Metadata

Metadata

Assignees

No one assigned

    Labels

    stabilityTasks that focus on improving stability, that includes tests, refining edge-cases, refactoring.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions