fix: Support for PrimitiveOffsetInfo in render pipeline draw...Indirect methods#2337
Open
cieplypolar wants to merge 13 commits intomainfrom
Open
fix: Support for PrimitiveOffsetInfo in render pipeline draw...Indirect methods#2337cieplypolar wants to merge 13 commits intomainfrom
PrimitiveOffsetInfo in render pipeline draw...Indirect methods#2337cieplypolar wants to merge 13 commits intomainfrom
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (349 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
cieplypolar
requested review from
aleksanderkatan,
Copilot,
iwoplaza and
reczkok
There was a problem hiding this comment.
Pull request overview
This PR addresses missing support for PrimitiveOffsetInfo-based offsets in render pipeline indirect draw methods, and extends indirect dispatch to accept raw GPUBuffers (aligning compute + render indirect APIs and adding runtime validation/warnings).
Changes:
- Add
PrimitiveOffsetInfo | numberoffset support (and stricterIndirectFlagtyping) fordrawIndirect/drawIndexedIndirect. - Allow
dispatchWorkgroupsIndirectto accept rawGPUBuffers, with consistent validation/warning behavior. - Centralize indirect offset/size validation into a new
resolveIndirectOffsetutility and add/extend tests + mocks.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/typegpu/src/core/pipeline/renderPipeline.ts | Updates indirect draw APIs to accept `PrimitiveOffsetInfo |
| packages/typegpu/src/core/pipeline/computePipeline.ts | Extends dispatchWorkgroupsIndirect to accept GPUBuffer and delegates offset validation to shared utility. |
| packages/typegpu/src/core/pipeline/pipelineUtils.ts | New shared helper for indirect offset resolution, alignment/size validation, and padding-contiguity warnings. |
| packages/typegpu/tests/renderPipeline.test.ts | Adds coverage for indirect draw buffer usage/offset validation and padding warnings. |
| packages/typegpu/tests/computePipeline.test.ts | Adds coverage for raw GPUBuffer indirect dispatch validation and warning behaviors. |
| packages/typegpu-testing-utility/src/extendedIt.ts | Extends render pass encoder mocks with indirect draw methods for new tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cieplypolar
changed the title
PrimitiveOffsetInfo in render pipeline draw...Indirect methodsPrimitiveOffsetInfo in render pipeline draw...Indirect methods
aleksanderkatan
approved these changes
Apr 3, 2026
Contributor
aleksanderkatan
left a comment
aleksanderkatan
left a comment
There was a problem hiding this comment.
Neat! 🐛🌊 I would just reconsider these warns, maybe they can just be a part of JSDocs?
reczkok
reviewed
Apr 7, 2026
Comment on lines
+44
to
+46
| console.warn( | ||
| `${operation}: Using raw GPUBuffer. Offset validation is limited. Wrap the GPUBuffer with \`root.createBuffer(...)\` for safe validation.`, | ||
| ); |
Contributor
There was a problem hiding this comment.
I would actually move away from this - if someone for some reason has to use a raw buffer I would not harass them. Either remove this or add an explicit way to silence the warning
| return offset; | ||
| } | ||
|
|
||
| let offsetInfo = start ?? memoryLayoutOf(indirectBuffer.dataType); |
Contributor
There was a problem hiding this comment.
Original message:
Even without the accessor this is an expensive thing to do (in case of the struct) potentially every frame with no obvious way for the user to opt out of. I think this is one of the APIs that is used in use cases where every 0.1ms of the cpu time matters so we have to be mindful of that.
Update:
I run some benchmarks and the cost of memoryLayoutOf (especially without the accessor) seems to be very low to the point where we are talking sub-microsecond so maybe it's fine
| if (offsetInfo === 0) { | ||
| offsetInfo = memoryLayoutOf(indirectBuffer.dataType); | ||
| } else { | ||
| console.warn( |
Contributor
There was a problem hiding this comment.
Again someone can just not care about this (knows the layout well and has no need for additional api calls) - I think we should respect that (I know this is my code - I changed my mind 
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2336.
Also I added
GPUBuffertodispatchWorkgroupsIndirectsignature.TODO: