chore: typegpu-cli minor improvements#2557
Merged
Merged
Conversation
|
pkg.pr.new packages benchmark commit |
📊 Bundle Size Comparison
👀 Notable resultsStatic test results:No major changes. Dynamic test results:No major changes. 📋 All resultsClick to reveal the results table (355 entries).
If you wish to run a comparison for other, slower bundlers, run the 'Tree-shake test' from the GitHub Actions menu. |
Resolution Time Benchmark---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Random Branching (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.90, 1.80, 4.32, 6.58, 7.71, 10.39, 20.32, 24.41]
line [0.93, 1.80, 3.85, 6.68, 8.56, 11.41, 21.55, 23.41]
line [0.92, 1.82, 4.00, 6.11, 7.30, 10.56, 19.73, 21.62]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Linear Recursion (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.31, 0.49, 0.65, 0.79, 1.05, 1.14, 1.40, 1.51]
line [0.31, 0.52, 0.65, 0.82, 1.14, 1.24, 1.44, 1.58]
line [0.31, 0.48, 0.68, 0.82, 1.12, 1.18, 1.44, 1.59]
---
config:
themeVariables:
xyChart:
plotColorPalette: "#E63946, #3B82F6, #059669"
---
xychart
title "Full Tree (🔴 PR | 🔵 main | 🟢 release)"
x-axis "max depth" [1, 2, 3, 4, 5, 6, 7, 8]
y-axis "time (ms)"
line [0.84, 1.91, 3.79, 6.14, 12.15, 25.12, 53.99, 110.09]
line [0.79, 2.08, 3.90, 6.10, 11.97, 25.15, 53.25, 110.67]
line [0.89, 1.87, 3.92, 6.38, 12.13, 25.20, 55.14, 110.39]
|
There was a problem hiding this comment.
Pull request overview
This PR makes small quality-of-life improvements to @typegpu/cli and the Vite-simple project template, primarily around linting/type-check workflows and generated template file formatting.
Changes:
- Adjust the Vite-simple template’s oxlint rules and add a
typesscript for quick type-checking without emit. - Simplify the
pmFromUserAgenttype assertion in the CLI utilities. - Ensure generated
package.jsonfiles end with a trailing newline to satisfyoxfmt --check.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/typegpu-cli/templates/template-vite-simple/oxlint.config.ts | Removes an explicit override disabling typescript/no-unsafe-type-assertion in the template’s oxlint config. |
| packages/typegpu-cli/templates/template-vite-simple/_package.json | Adds types script and fixes JSON trailing comma formatting. |
| packages/typegpu-cli/src/utils/pm.ts | Replaces a double-cast (as unknown as Agent) with a direct cast (as Agent). |
| packages/typegpu-cli/src/utils/files.ts | Appends a newline when writing generated package.json to keep oxfmt checks passing. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
Only this comment remained unaddressed. |
iwoplaza
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.