dont duplicate code

Author: GuzekAlan

lib/live_debugger_web/helpers/state_helper.ex

@@ -0,0 +1,20 @@
+defmodule LiveDebuggerWeb.Helpers.StateHelper do
+  @moduledoc """
+  This module has helper functions for managing state
+  """
+  alias LiveDebugger.CommonTypes
+  alias LiveDebugger.Services.ChannelService
+
+  @doc """
+  Fetches state using ChannelService when no state is passed
+  """
+  @spec maybe_get_state(pid :: pid(), channel_state :: CommonTypes.channel_state() | nil) ::
+          {:ok, CommonTypes.channel_state()} | {:error, term()}
+  def maybe_get_state(pid, channel_state \\ nil) when is_pid(pid) do
+    if is_nil(channel_state) do
+      ChannelService.state(pid)
+    else
+      {:ok, channel_state}
+    end
+  end
+end

lib/live_debugger_web/live/sidebar_live.ex

@@ -18,6 +18,7 @@ defmodule LiveDebuggerWeb.SidebarLive do
   alias LiveDebugger.Utils.URL
   alias LiveDebuggerWeb.LiveComponents.NestedLiveViewsLinks
   alias LiveDebugger.Utils.PubSub, as: PubSubUtils
+  alias LiveDebuggerWeb.Helpers.StateHelper
 
   attr(:socket, :map, required: true)
   attr(:id, :string, required: true)
@@ -341,7 +342,7 @@ defmodule LiveDebuggerWeb.SidebarLive do
     pid = socket.assigns.lv_process.pid
 
     assign_async(socket, [:tree, :max_opened_node_level], fn ->
-      with {:ok, channel_state} <- maybe_get_state(pid, state),
+      with {:ok, channel_state} <- StateHelper.maybe_get_state(pid, state),
            {:ok, tree} <- ChannelService.build_tree(channel_state) do
         {:ok, %{tree: tree, max_opened_node_level: Tree.max_opened_node_level(tree)}}
       else
@@ -380,12 +381,4 @@ defmodule LiveDebuggerWeb.SidebarLive do
 
     send(state.socket.transport_pid, state.serializer.encode!(message))
   end
-
-  defp maybe_get_state(pid, channel_state) do
-    if is_nil(channel_state) do
-      ChannelService.state(pid)
-    else
-      {:ok, channel_state}
-    end
-  end
 end

lib/live_debugger_web/live/state_live.ex

@@ -13,6 +13,7 @@ defmodule LiveDebuggerWeb.StateLive do
   alias LiveDebugger.Services.ChannelService
   alias LiveDebugger.Utils.TermParser
   alias LiveDebugger.Utils.PubSub, as: PubSubUtils
+  alias LiveDebuggerWeb.Helpers.StateHelper
 
   attr(:socket, :map, required: true)
   attr(:id, :string, required: true)
@@ -167,7 +168,7 @@ defmodule LiveDebuggerWeb.StateLive do
        )
        when not is_nil(node_id) do
     assign_async(socket, [:node, :node_type], fn ->
-      with {:ok, channel_state} <- maybe_get_state(pid, channel_state),
+      with {:ok, channel_state} <- StateHelper.maybe_get_state(pid, channel_state),
            {:ok, node} <- ChannelService.get_node(channel_state, node_id),
            true <- not is_nil(node) do
         {:ok, %{node: node, node_type: TreeNode.type(node)}}
@@ -184,14 +185,6 @@ defmodule LiveDebuggerWeb.StateLive do
     |> assign(:node_type, AsyncResult.failed(%AsyncResult{}, :no_node_id))
   end
 
-  defp maybe_get_state(pid, channel_state) do
-    if is_nil(channel_state) do
-      ChannelService.state(pid)
-    else
-      {:ok, channel_state}
-    end
-  end
-
   defp title(:live_component), do: "LiveComponent"
   defp title(:live_view), do: "LiveView"