Skip to content

Commit 3466489

Browse files
authored
Fix: scrollbar placement in Node Inspector (#985)
1 parent cc11493 commit 3466489

3 files changed

Lines changed: 40 additions & 40 deletions

File tree

lib/live_debugger/app/debugger/web/components/pages.ex

Lines changed: 40 additions & 38 deletions
Original file line numberDiff line numberDiff line change
@@ -47,44 +47,46 @@ defmodule LiveDebugger.App.Debugger.Web.Components.Pages do
4747
dropdown_id="node-inspector"
4848
/>
4949
50-
<div class="flex flex-col max-w-screen-2xl w-full gap-4 p-8 overflow-y-auto">
51-
<.live_component
52-
module={NodeBasicInfo}
53-
id="node-inspector-basic-info"
54-
lv_process={@lv_process}
55-
node_id={@node_id}
56-
/>
57-
58-
<NodeStateLive.live_render
59-
id="node-state-lv"
60-
class="flex"
61-
socket={@socket}
62-
lv_process={@lv_process}
63-
node_id={@node_id}
64-
/>
65-
66-
<AsyncJobsLive.live_render
67-
id="async-jobs-lv"
68-
class="flex"
69-
socket={@socket}
70-
lv_process={@lv_process}
71-
node_id={@node_id}
72-
/>
73-
<StreamsLive.live_render
74-
id="streams-list"
75-
class="flex"
76-
socket={@socket}
77-
lv_process={@lv_process}
78-
node_id={@node_id}
79-
/>
80-
81-
<CallbackTracingWeb.NodeTracesLive.live_render
82-
id="traces-list"
83-
class="flex"
84-
socket={@socket}
85-
lv_process={@lv_process}
86-
node_id={@node_id}
87-
/>
50+
<div class="w-full overflow-y-auto">
51+
<div class="flex flex-col max-w-screen-2xl w-full gap-4 p-8 mx-auto">
52+
<.live_component
53+
module={NodeBasicInfo}
54+
id="node-inspector-basic-info"
55+
lv_process={@lv_process}
56+
node_id={@node_id}
57+
/>
58+
59+
<NodeStateLive.live_render
60+
id="node-state-lv"
61+
class="flex"
62+
socket={@socket}
63+
lv_process={@lv_process}
64+
node_id={@node_id}
65+
/>
66+
67+
<AsyncJobsLive.live_render
68+
id="async-jobs-lv"
69+
class="flex"
70+
socket={@socket}
71+
lv_process={@lv_process}
72+
node_id={@node_id}
73+
/>
74+
<StreamsLive.live_render
75+
id="streams-list"
76+
class="flex"
77+
socket={@socket}
78+
lv_process={@lv_process}
79+
node_id={@node_id}
80+
/>
81+
82+
<CallbackTracingWeb.NodeTracesLive.live_render
83+
id="traces-list"
84+
class="flex"
85+
socket={@socket}
86+
lv_process={@lv_process}
87+
node_id={@node_id}
88+
/>
89+
</div>
8890
</div>
8991
</div>
9092
<.live_component module={NodeInspectorSidebar} id={@sidebar_id} trigger_sidebar={@trigger_sidebar}>

test/services/callback_tracer/actions/tracing_test.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ defmodule LiveDebugger.Services.CallbackTracer.Actions.TracingTest do
1414
alias LiveDebugger.MockBus
1515
alias LiveDebugger.Services.CallbackTracer.Actions.Tracing, as: TracingActions
1616
alias LiveDebugger.Services.CallbackTracer.Events.DbgStarted
17-
alias LiveDebugger.Utils.Versions
1817

1918
setup :verify_on_exit!
2019

test/services/callback_tracer/gen_servers/tracing_manager_test.exs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ defmodule LiveDebugger.Services.CallbackTracer.GenServers.TracingManagerTest do
1313
alias LiveDebugger.Services.CallbackTracer.Events.DbgStarted
1414
alias LiveDebugger.Services.CallbackTracer.GenServers.TracingManager
1515
alias LiveDebugger.Services.ProcessMonitor.Events.LiveViewBorn
16-
alias LiveDebugger.Utils.Versions
1716

1817
setup :verify_on_exit!
1918

0 commit comments

Comments
 (0)