Skip to content

Commit fe71b05

Browse files
authored
Bug: Fix assigns not scrollable (#294)
* make assigns scrollable on desktop view * pass class to live_render
1 parent 9ee99b9 commit fe71b05

4 files changed

Lines changed: 20 additions & 14 deletions

File tree

lib/live_debugger/live_views/channel_dashboard_live.ex

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -65,24 +65,24 @@ defmodule LiveDebugger.LiveViews.ChannelDashboardLive do
6565
<div class="flex overflow-hidden">
6666
<SidebarLive.live_render
6767
id="sidebar"
68+
class="h-full"
6869
socket={@socket}
6970
lv_process={lv_process}
7071
url={@url}
7172
node_id={@node_id || lv_process.pid}
7273
/>
7374
7475
<div class="flex grow flex-col xl:flex-row gap-4 xl:gap-8 p-8 overflow-y-auto xl:overflow-y-hidden max-w-screen-2xl mx-auto scrollbar-main">
75-
<div class="xl:w-1/2">
76-
<StateLive.live_render
77-
id="node-state-lv"
78-
socket={@socket}
79-
lv_process={lv_process}
80-
node_id={@node_id || lv_process.pid}
81-
/>
82-
</div>
76+
<StateLive.live_render
77+
id="node-state-lv"
78+
class="flex xl:w-1/2"
79+
socket={@socket}
80+
lv_process={lv_process}
81+
node_id={@node_id || lv_process.pid}
82+
/>
8383
<TracesLive.live_render
8484
id="traces-list"
85-
class="xl:w-1/2"
85+
class="flex max-xl:grow xl:w-1/2"
8686
socket={@socket}
8787
lv_process={lv_process}
8888
node_id={@node_id || lv_process.pid}

lib/live_debugger/live_views/sidebar_live.ex

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
2424
attr(:lv_process, :map, required: true)
2525
attr(:node_id, :string, required: true)
2626
attr(:url, :string, required: true)
27+
attr(:class, :string, default: "", doc: "CSS class for the container")
2728

2829
def live_render(assigns) do
2930
session = %{
@@ -39,7 +40,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
3940
<%= live_render(@socket, __MODULE__,
4041
id: @id,
4142
session: @session,
42-
container: {:aside, class: "h-full"}
43+
container: {:aside, class: @class}
4344
) %>
4445
"""
4546
end

lib/live_debugger/live_views/state_live.ex

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ defmodule LiveDebugger.LiveViews.StateLive do
1818
attr(:id, :string, required: true)
1919
attr(:lv_process, :map, required: true)
2020
attr(:node_id, :string, required: true)
21+
attr(:class, :string, default: "", doc: "CSS class for the container")
2122

2223
def live_render(assigns) do
2324
session = %{
@@ -29,7 +30,11 @@ defmodule LiveDebugger.LiveViews.StateLive do
2930
assigns = assign(assigns, session: session)
3031

3132
~H"""
32-
<%= live_render(@socket, __MODULE__, id: @id, session: @session) %>
33+
<%= live_render(@socket, __MODULE__,
34+
id: @id,
35+
session: @session,
36+
container: {:div, class: @class}
37+
) %>
3338
"""
3439
end
3540

@@ -59,7 +64,7 @@ defmodule LiveDebugger.LiveViews.StateLive do
5964
@impl true
6065
def render(assigns) do
6166
~H"""
62-
<div class="flex flex-col gap-4 xl:items-end">
67+
<div class="flex-1 max-w-full flex flex-col gap-4">
6368
<.async_result :let={node} assign={@node}>
6469
<:loading>
6570
<div class="w-full flex items-center justify-center">

lib/live_debugger/live_views/traces_live.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do
2525
attr(:lv_process, :map, required: true)
2626
attr(:node_id, :string, required: true)
2727
attr(:root_pid, :any, required: true)
28-
attr(:class, :string, required: true)
28+
attr(:class, :string, default: "", doc: "CSS class for the container")
2929

3030
def live_render(assigns) do
3131
session = %{
@@ -42,7 +42,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do
4242
<%= live_render(@socket, __MODULE__,
4343
id: @id,
4444
session: @session,
45-
container: {:div, class: "flex #{@class}"}
45+
container: {:div, class: @class}
4646
) %>
4747
"""
4848
end

0 commit comments

Comments
 (0)