Custom LiveDebugger server URL only applied to assets

[rhcarvalho]

Bug Description

Following up on #426, https://github.com/software-mansion/live-debugger/pull/442/files/b372a426816c370f39d270e75686ebb658509471#r2111453214

Trying to use the new :external_url config leaves LiveDebugger partially working when developing in a containerized environment.

mix.exs:

      {:live_debugger, "~> 0.2",
       only: :dev,
       github: "software-mansion/live-debugger",
       # commit ref from software-mansion/live-debugger#442 
       ref: "b15deac51ee710fa78c8026ab9ab49cea4d03c3a"},

config/dev.exs:

ip =
  if System.get_env("DEV_CONTAINER") == "1" do
    # All interfaces
    {0, 0, 0, 0}
  else
    # Loopback address
    {127, 0, 0, 1}
  end

# ...

config :live_debugger, ip: ip, external_url: "http://localhost:9007"

Application is running in a Linux container with port-forwarding, docker-compose.yml:

    ports:
      - "127.0.0.1:8087:4000"
      - "127.0.0.1:9007:4007" # LiveDebugger

Actual Behavior

The JS assets are loaded correctly from http://localhost:9007, but the LiveDebugger link points to the wrong URL, http://0.0.0.0:4007 (this is the server URL).

Expected Behavior

The link should point to the configured external URL: http://localhost:9007.

Steps to Reproduce

As per description above.

Elixir version with Erlang/OTP

Erlang/OTP 27 [erts-15.2.7] [source] [64-bit] [smp:8:8] [ds:8:8:10] [async-threads:1] [jit:ns] Elixir 1.18.4 (compiled with Erlang/OTP 27)

LiveDebugger version

• live_debugger 0.2.3 (https://github.com/software-mansion/live-debugger.git - b15deac) (mix) locked at b15deac (ref)

Phoenix version

• phoenix 1.7.21 (Hex package) (mix) locked at 1.7.21 (phoenix) 336dce4f

Phoenix LiveView version

• phoenix_live_view 1.0.13 (Hex package) (mix) locked at 1.0.13 (phoenix_live_view) c6985029

Operating system

Linux

Browser(s)

Chrome

[rhcarvalho]

I applied this patch locally and confirmed after rebuilding the dependency it worked as expected:

diff --git lib/live_debugger.ex lib/live_debugger.ex
index 5b58f41..f8b6767 100644
--- lib/live_debugger.ex
+++ lib/live_debugger.ex
@@ -80,14 +80,13 @@ defmodule LiveDebugger do
   defp put_live_debugger_tags(config) do
     ip_string = config |> Keyword.get(:ip, @default_ip) |> :inet.ntoa() |> List.to_string()
     port = Keyword.get(config, :port, @default_port)
-    live_debugger_url = "http://#{ip_string}:#{port}"
+    live_debugger_url = Keyword.get(config, :external_url, "http://#{ip_string}:#{port}")
 
     browser_features? = Keyword.get(config, :browser_features?, true)
     debug_button? = Keyword.get(config, :debug_button?, true)
     highlighting? = Keyword.get(config, :highlighting?, true)
-    external_url = Keyword.get(config, :external_url, live_debugger_url)
 
-    live_debugger_assets_url = "#{external_url}/#{@assets_path}"
+    live_debugger_assets_url = "#{live_debugger_url}/#{@assets_path}"
 
     assigns = %{
       url: live_debugger_url,