Skip to content

Bug: Remove multiple ids from components tree #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuzekAlan merged 1 commit into from
Apr 23, 2025
Merged

Bug: Remove multiple ids from components tree #286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions lib/live_debugger/components/tree.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ defmodule LiveDebugger.Components.Tree do
To calculate `max_opened_node_level` it uses `max_nesting_level/2` function.
"""

attr(:id, :string, required: true, doc: "The id of the tree")
attr(:tree_node, :any, required: true, doc: "The TreeNode struct to render")
attr(:title, :string, required: true, doc: "The title of the tree")
attr(:selected_node_id, :string, required: true, doc: "The id of the selected node")
Expand All @@ -39,6 +40,7 @@ defmodule LiveDebugger.Components.Tree do
</div>
<div class="w-full px-1 overflow-y-auto">
<.tree_node
tree_id={@id}
tree_node={@tree_node}
selected_node_id={@selected_node_id}
root?={true}
Expand Down Expand Up @@ -71,6 +73,7 @@ defmodule LiveDebugger.Components.Tree do
|> elem(0)
end

attr(:tree_id, :string, required: true)
attr(:parent_dom_id, :string, default: nil)
attr(:tree_node, :any, required: true)
attr(:selected_node_id, :string, default: nil)
Expand All @@ -91,14 +94,15 @@ defmodule LiveDebugger.Components.Tree do
<div class="w-full">
<.collapsible
:if={@collapsible?}
id={"collapsible-" <> @tree_node.parsed_id}
id={"collapsible-#{@tree_node.parsed_id}-#{@tree_id}"}
chevron_class="text-accent-icon h-5 w-5"
open={@open}
label_class="w-full rounded-md py-1 hover:bg-surface-1-bg-hover"
style={style_for_padding(@level, @collapsible?)}
>
<:label>
<.label
tree_id={@tree_id}
selected?={@selected?}
parent_dom_id={@parent_dom_id}
node={@tree_node}
Expand All @@ -109,6 +113,7 @@ defmodule LiveDebugger.Components.Tree do
<div class="flex flex-col">
<.tree_node
:for={child <- @tree_node.children}
tree_id={@tree_id}
parent_dom_id={if @tree_node[:dom_id], do: @tree_node.dom_id, else: @parent_dom_id}
tree_node={child}
selected_node_id={@selected_node_id}
Expand All @@ -120,6 +125,7 @@ defmodule LiveDebugger.Components.Tree do
</.collapsible>
<.label
:if={not @collapsible?}
tree_id={@tree_id}
selected?={@selected?}
parent_dom_id={@parent_dom_id}
node={@tree_node}
Expand All @@ -131,6 +137,7 @@ defmodule LiveDebugger.Components.Tree do
"""
end

attr(:tree_id, :string, required: true)
attr(:parent_dom_id, :string, required: true)
attr(:node, :any, required: true)
attr(:level, :integer, required: true)
Expand All @@ -144,7 +151,7 @@ defmodule LiveDebugger.Components.Tree do

~H"""
<button
id={"tree_node_button_" <> @node.parsed_id}
id={"tree-node-button-#{@node.parsed_id}-#{@tree_id}"}
phx-click="select_node"
phx-value-node_id={@node.parsed_id}
phx-value-search-attribute={get_search_attribute(@node)}
Expand All @@ -160,7 +167,7 @@ defmodule LiveDebugger.Components.Tree do
<div class="flex w-full gap-0.5 items-center">
<.icon name={@node.icon} class="text-accent-icon w-5 h-5 shrink-0" />
<.tooltip
id={"tree_node_" <> @node.parsed_id}
id={"tree-node-#{@node.parsed_id}-#{@tree_id}"}
content={@node.tooltip}
class="w-full flex overflow-x-hidden"
>
Expand Down
3 changes: 3 additions & 0 deletions lib/live_debugger/live_views/sidebar_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
lv_process={@lv_process}
/>
<.component_tree
id={@id}
tree={@tree}
selected_node_id={@node_id}
max_opened_node_level={@max_opened_node_level}
Expand Down Expand Up @@ -285,6 +286,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
"""
end

attr(:id, :string, required: true)
attr(:tree, :any, required: true)
attr(:max_opened_node_level, :any, required: true)
attr(:selected_node_id, :string, default: nil)
Expand All @@ -302,6 +304,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do

<Tree.tree
:if={tree}
id={"component-tree-" <> @id}
title="Components Tree"
selected_node_id={@selected_node_id}
tree_node={tree}
Expand Down