From a8ab10f6e71ef5e4c8eee74a52295fdf62df69af Mon Sep 17 00:00:00 2001 From: Alan Guzek Date: Wed, 23 Apr 2025 16:44:41 +0200 Subject: [PATCH 1/3] make assigns scrollable on desktop view --- .../live_views/channel_dashboard_live.ex | 15 ++++++--------- lib/live_debugger/live_views/state_live.ex | 8 ++++++-- lib/live_debugger/live_views/traces_live.ex | 3 +-- 3 files changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/live_debugger/live_views/channel_dashboard_live.ex b/lib/live_debugger/live_views/channel_dashboard_live.ex index ee9094974..26f3299bc 100644 --- a/lib/live_debugger/live_views/channel_dashboard_live.ex +++ b/lib/live_debugger/live_views/channel_dashboard_live.ex @@ -72,17 +72,14 @@ defmodule LiveDebugger.LiveViews.ChannelDashboardLive do />
-
- -
+ + <%= live_render(@socket, __MODULE__, + id: @id, + session: @session, + container: {:div, class: "flex xl:w-1/2"} + ) %> """ end @@ -59,7 +63,7 @@ defmodule LiveDebugger.LiveViews.StateLive do @impl true def render(assigns) do ~H""" -
+
<.async_result :let={node} assign={@node}> <:loading>
diff --git a/lib/live_debugger/live_views/traces_live.ex b/lib/live_debugger/live_views/traces_live.ex index 01de66b34..cec4cd139 100644 --- a/lib/live_debugger/live_views/traces_live.ex +++ b/lib/live_debugger/live_views/traces_live.ex @@ -25,7 +25,6 @@ defmodule LiveDebugger.LiveViews.TracesLive do attr(:lv_process, :map, required: true) attr(:node_id, :string, required: true) attr(:root_pid, :any, required: true) - attr(:class, :string, required: true) def live_render(assigns) do session = %{ @@ -42,7 +41,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do <%= live_render(@socket, __MODULE__, id: @id, session: @session, - container: {:div, class: "flex #{@class}"} + container: {:div, class: "flex xl:w-1/2"} ) %> """ end From e6d6f0d69bae95bb0d7eb98674e0920d66e9e1f2 Mon Sep 17 00:00:00 2001 From: Alan Guzek Date: Wed, 23 Apr 2025 16:56:04 +0200 Subject: [PATCH 2/3] take full space on smaller contents --- lib/live_debugger/live_views/state_live.ex | 2 +- lib/live_debugger/live_views/traces_live.ex | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/live_debugger/live_views/state_live.ex b/lib/live_debugger/live_views/state_live.ex index f319119af..4a0bbaf85 100644 --- a/lib/live_debugger/live_views/state_live.ex +++ b/lib/live_debugger/live_views/state_live.ex @@ -63,7 +63,7 @@ defmodule LiveDebugger.LiveViews.StateLive do @impl true def render(assigns) do ~H""" -
+
<.async_result :let={node} assign={@node}> <:loading>
diff --git a/lib/live_debugger/live_views/traces_live.ex b/lib/live_debugger/live_views/traces_live.ex index cec4cd139..497163463 100644 --- a/lib/live_debugger/live_views/traces_live.ex +++ b/lib/live_debugger/live_views/traces_live.ex @@ -41,7 +41,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do <%= live_render(@socket, __MODULE__, id: @id, session: @session, - container: {:div, class: "flex xl:w-1/2"} + container: {:div, class: "flex max-xl:grow xl:w-1/2"} ) %> """ end From 2e7088679aa982c6083ef522eae9acdb042fd3fa Mon Sep 17 00:00:00 2001 From: Alan Guzek Date: Thu, 24 Apr 2025 11:14:22 +0200 Subject: [PATCH 3/3] pass class to live_render --- lib/live_debugger/live_views/channel_dashboard_live.ex | 3 +++ lib/live_debugger/live_views/sidebar_live.ex | 3 ++- lib/live_debugger/live_views/state_live.ex | 3 ++- lib/live_debugger/live_views/traces_live.ex | 3 ++- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/lib/live_debugger/live_views/channel_dashboard_live.ex b/lib/live_debugger/live_views/channel_dashboard_live.ex index 26f3299bc..93694fd5f 100644 --- a/lib/live_debugger/live_views/channel_dashboard_live.ex +++ b/lib/live_debugger/live_views/channel_dashboard_live.ex @@ -65,6 +65,7 @@ defmodule LiveDebugger.LiveViews.ChannelDashboardLive do
""" end diff --git a/lib/live_debugger/live_views/state_live.ex b/lib/live_debugger/live_views/state_live.ex index 4a0bbaf85..c8742625d 100644 --- a/lib/live_debugger/live_views/state_live.ex +++ b/lib/live_debugger/live_views/state_live.ex @@ -18,6 +18,7 @@ defmodule LiveDebugger.LiveViews.StateLive do attr(:id, :string, required: true) attr(:lv_process, :map, required: true) attr(:node_id, :string, required: true) + attr(:class, :string, default: "", doc: "CSS class for the container") def live_render(assigns) do session = %{ @@ -32,7 +33,7 @@ defmodule LiveDebugger.LiveViews.StateLive do <%= live_render(@socket, __MODULE__, id: @id, session: @session, - container: {:div, class: "flex xl:w-1/2"} + container: {:div, class: @class} ) %> """ end diff --git a/lib/live_debugger/live_views/traces_live.ex b/lib/live_debugger/live_views/traces_live.ex index 497163463..777374f2b 100644 --- a/lib/live_debugger/live_views/traces_live.ex +++ b/lib/live_debugger/live_views/traces_live.ex @@ -25,6 +25,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do attr(:lv_process, :map, required: true) attr(:node_id, :string, required: true) attr(:root_pid, :any, required: true) + attr(:class, :string, default: "", doc: "CSS class for the container") def live_render(assigns) do session = %{ @@ -41,7 +42,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do <%= live_render(@socket, __MODULE__, id: @id, session: @session, - container: {:div, class: "flex max-xl:grow xl:w-1/2"} + container: {:div, class: @class} ) %> """ end