Skip to content

Bug: Fix assigns not scrollable #294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GuzekAlan merged 3 commits into from
Apr 24, 2025
Merged

Bug: Fix assigns not scrollable #294

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a8ab10f
make assigns scrollable on desktop view
GuzekAlan Apr 23, 2025
e6d6f0d
take full space on smaller contents
GuzekAlan Apr 23, 2025
2e70886
pass class to live_render
GuzekAlan Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions lib/live_debugger/live_views/channel_dashboard_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,24 +65,24 @@ defmodule LiveDebugger.LiveViews.ChannelDashboardLive do
<div class="flex overflow-hidden">
<SidebarLive.live_render
id="sidebar"
class="h-full"
socket={@socket}
lv_process={lv_process}
url={@url}
node_id={@node_id || lv_process.pid}
/>

<div class="flex grow flex-col xl:flex-row gap-4 xl:gap-8 p-8 overflow-y-auto xl:overflow-y-hidden max-w-screen-2xl mx-auto scrollbar-main">
<div class="xl:w-1/2">
<StateLive.live_render
id="node-state-lv"
socket={@socket}
lv_process={lv_process}
node_id={@node_id || lv_process.pid}
/>
</div>
<StateLive.live_render
id="node-state-lv"
class="flex xl:w-1/2"
socket={@socket}
lv_process={lv_process}
node_id={@node_id || lv_process.pid}
/>
<TracesLive.live_render
id="traces-list"
class="xl:w-1/2"
Comment thread
GuzekAlan marked this conversation as resolved.
class="flex max-xl:grow xl:w-1/2"
socket={@socket}
lv_process={lv_process}
node_id={@node_id || lv_process.pid}
Expand Down
3 changes: 2 additions & 1 deletion lib/live_debugger/live_views/sidebar_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
attr(:lv_process, :map, required: true)
attr(:node_id, :string, required: true)
attr(:url, :string, required: true)
attr(:class, :string, default: "", doc: "CSS class for the container")

def live_render(assigns) do
session = %{
Expand All @@ -39,7 +40,7 @@ defmodule LiveDebugger.LiveViews.SidebarLive do
<%= live_render(@socket, __MODULE__,
id: @id,
session: @session,
container: {:aside, class: "h-full"}
container: {:aside, class: @class}
) %>
"""
end
Expand Down
9 changes: 7 additions & 2 deletions lib/live_debugger/live_views/state_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ defmodule LiveDebugger.LiveViews.StateLive do
attr(:id, :string, required: true)
attr(:lv_process, :map, required: true)
attr(:node_id, :string, required: true)
attr(:class, :string, default: "", doc: "CSS class for the container")

def live_render(assigns) do
session = %{
Expand All @@ -29,7 +30,11 @@ defmodule LiveDebugger.LiveViews.StateLive do
assigns = assign(assigns, session: session)

~H"""
<%= live_render(@socket, __MODULE__, id: @id, session: @session) %>
<%= live_render(@socket, __MODULE__,
id: @id,
session: @session,
container: {:div, class: @class}
) %>
"""
end

Expand Down Expand Up @@ -59,7 +64,7 @@ defmodule LiveDebugger.LiveViews.StateLive do
@impl true
def render(assigns) do
~H"""
<div class="flex flex-col gap-4 xl:items-end">
<div class="flex-1 max-w-full flex flex-col gap-4">
<.async_result :let={node} assign={@node}>
<:loading>
<div class="w-full flex items-center justify-center">
Expand Down
4 changes: 2 additions & 2 deletions lib/live_debugger/live_views/traces_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do
attr(:lv_process, :map, required: true)
attr(:node_id, :string, required: true)
attr(:root_pid, :any, required: true)
attr(:class, :string, required: true)
attr(:class, :string, default: "", doc: "CSS class for the container")

def live_render(assigns) do
session = %{
Expand All @@ -42,7 +42,7 @@ defmodule LiveDebugger.LiveViews.TracesLive do
<%= live_render(@socket, __MODULE__,
id: @id,
session: @session,
container: {:div, class: "flex #{@class}"}
container: {:div, class: @class}
) %>
"""
end
Expand Down