Skip to content

Bug: Fix triggering highlighting on hover #353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraleppa merged 1 commit into from
May 6, 2025
Merged

Bug: Fix triggering highlighting on hover #353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions lib/live_debugger_web/components/tree.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ defmodule LiveDebuggerWeb.Components.Tree do
You need to pass TreeNode struct to render the tree.
This component emits `select_node` event with `node_id` param when a node is clicked. `node_id` is parsed.
To calculate `max_opened_node_level` it uses `max_nesting_level/2` function.
Clicking on the node will emit `select_node` event with params: `node-id`, `search-attribute`, `search-value`.
"""

attr(:id, :string, required: true, doc: "The id of the tree")
Expand Down Expand Up @@ -144,10 +145,15 @@ defmodule LiveDebuggerWeb.Components.Tree do
assigns =
assigns
|> assign(:padding_style, style_for_padding(assigns.level, assigns.collapsible?))
|> assign(:id, "tree-node-#{assigns.node.parsed_id}-#{assigns.tree_id}")
|> assign(:button_id, "tree-node-button-#{assigns.node.parsed_id}-#{assigns.tree_id}")

~H"""
<span
id={@id}
phx-hook="Highlight"
phx-value-search-attribute={get_search_attribute(@node)}
phx-value-search-value={get_search_value(@node, @parent_dom_id)}
class={[
"flex shrink grow items-center rounded-md hover:bg-surface-1-bg-hover",
if(!@collapsible?, do: "p-1")
Expand All @@ -156,9 +162,8 @@ defmodule LiveDebuggerWeb.Components.Tree do
>
<button
id={@button_id}
phx-hook="Highlight"
phx-click="select_node"
phx-value-node_id={@node.parsed_id}
phx-value-node-id={@node.parsed_id}
phx-value-search-attribute={get_search_attribute(@node)}
phx-value-search-value={get_search_value(@node, @parent_dom_id)}
class="flex min-w-0 gap-0.5 items-center"
Expand Down
8 changes: 5 additions & 3 deletions lib/live_debugger_web/live/sidebar_live.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,9 +153,11 @@ defmodule LiveDebuggerWeb.SidebarLive do
end

@impl true
def handle_event("select_node", params, socket) do
%{"node_id" => node_id, "search-attribute" => attr, "search-value" => val} = params

def handle_event(
"select_node",
%{"node-id" => node_id, "search-attribute" => attr, "search-value" => val},
socket
) do
if LiveDebugger.Feature.enabled?(:highlighting) do
if !socket.assigns.hidden? && socket.assigns.highlight? do
send_event(socket.assigns.lv_process.pid, "highlight", %{attr: attr, val: val})
Expand Down