Skip to content

Enhancement: Create form for filtering by execution time#361

Merged
hhubert6 merged 8 commits into
mainfrom
359-create-form-for-filtering-by-execution-time
May 14, 2025
Merged

Enhancement: Create form for filtering by execution time#361
hhubert6 merged 8 commits into
mainfrom
359-create-form-for-filtering-by-execution-time

Conversation

@hhubert6
Copy link
Copy Markdown
Contributor

@hhubert6 hhubert6 commented May 6, 2025

Form design is not final. It's just for this feature to work.

@hhubert6 hhubert6 linked an issue May 6, 2025 that may be closed by this pull request
@hhubert6 hhubert6 requested review from GuzekAlan and kraleppa May 12, 2025 07:02
Copy link
Copy Markdown
Member

@kraleppa kraleppa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that this is form only that is not filtering yet, right? I'm asking since execution time does not appear in my case at all

Screen.Recording.2025-05-12.at.10.26.36.mov

Comment thread lib/live_debugger_web/components.ex Outdated
Comment thread lib/live_debugger_web/components.ex Outdated
Comment thread lib/live_debugger_web/components.ex Outdated
Comment thread lib/live_debugger_web/components.ex Outdated
Comment thread lib/live_debugger_web/live_components/filters_form.ex Outdated
Comment thread lib/live_debugger_web/live_components/filters_form.ex Outdated
@hhubert6 hhubert6 requested a review from kraleppa May 13, 2025 08:58
Copy link
Copy Markdown
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

You can pass greater min value than max value but since UI might change it can be resolved in later PR with connecting to actual filtering

Comment thread lib/live_debugger_web/live_components/filters_form.ex
Comment thread lib/live_debugger_web/components.ex
@hhubert6 hhubert6 merged commit ed398fd into main May 14, 2025
1 check passed
@hhubert6 hhubert6 deleted the 359-create-form-for-filtering-by-execution-time branch May 14, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Create form for filtering by execution time

3 participants