Skip to content

Refactor: simplified routing and created linked_view hook#376

Merged
kraleppa merged 16 commits into
mainfrom
368-rework-livedebugger-routing-and-pid-loading
May 13, 2025
Merged

Refactor: simplified routing and created linked_view hook#376
kraleppa merged 16 commits into
mainfrom
368-rework-livedebugger-routing-and-pid-loading

Conversation

@kraleppa
Copy link
Copy Markdown
Member

@kraleppa kraleppa commented May 12, 2025

Most of it are tests 💀

@kraleppa kraleppa requested review from GuzekAlan and hhubert6 May 12, 2025 12:33
@kraleppa kraleppa linked an issue May 12, 2025 that may be closed by this pull request
Comment thread lib/live_debugger_web/hooks/linked_view.ex
Comment thread lib/live_debugger/services/live_view_discovery_service.ex
Comment thread lib/live_debugger_web/hooks/linked_view.ex Outdated
Comment thread lib/live_debugger_web/hooks/linked_view.ex
Comment thread lib/live_debugger/services/live_view_discovery_service.ex Outdated
Comment thread lib/live_debugger/services/live_view_discovery_service.ex Outdated
@kraleppa kraleppa requested a review from GuzekAlan May 12, 2025 15:28
Copy link
Copy Markdown
Contributor

@GuzekAlan GuzekAlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Work 💪

If you want you can merge first and I will rebase after or you could wait. I'm fine either way

Comment thread lib/live_debugger/services/live_view_discovery_service.ex
@kraleppa kraleppa merged commit 790abd2 into main May 13, 2025
1 check passed
@kraleppa kraleppa deleted the 368-rework-livedebugger-routing-and-pid-loading branch May 13, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rework LiveDebugger routing and PID loading

2 participants