POC: Inspecting LiveVIew#383
Conversation
There was a problem hiding this comment.
I really like your approach - it's really creative and having components inspection working not only for DevTools is game-changer.
However I have thought. We are already sending events via debugged application websocket (associated with highlighting). Now we'll have even more events coming from server to client and we also have client server communication (the post request you make)
Maybe we should create a separate websocket for LiveDebugger communication and move whole LiveDebugger communication there? In the browser we should have phoenix socket already defined and we should be able to easily declare a new socket on the server side (since we have a new endpoint)
| {:phoenix_live_view, "~> 0.20 or ~> 1.0"}, | ||
| {:igniter, "~> 0.5 and >= 0.5.40", optional: true}, | ||
| {:bandit, "~> 1.6", only: [:dev, :test]}, | ||
| {:cors_plug, "~> 3.0"}, |
There was a problem hiding this comment.
Is it really necessary to add this dep?
As I understand we will create a separate socket which will be registered using our |
|
@GuzekAlan exactly |
2 participants
No description provided.