Skip to content

Bug: fix duplicated ids in toggle_switch component #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kraleppa merged 1 commit into from
May 28, 2025
Merged

Bug: fix duplicated ids in toggle_switch component #446

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion lib/live_debugger_web/components.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -599,6 +599,7 @@ defmodule LiveDebuggerWeb.Components do
attr(:checked, :boolean, default: false, doc: "Whether the switch is checked.")
attr(:label, :string, default: "", doc: "Label for the switch.")
attr(:wrapper_class, :any, default: nil, doc: "Additional classes to add to the switch.")
attr(:id, :string, default: nil, doc: "ID of the switch.")
attr(:rest, :global)

def toggle_switch(assigns) do
Expand All @@ -610,7 +611,7 @@ defmodule LiveDebuggerWeb.Components do
<span class="text-xs font-normal text-primary-text mx-2">
<%= @label %>
</span>
<input id="highlight-switch" type="checkbox" class="sr-only peer" checked={@checked} {@rest} />
<input id={@id} type="checkbox" class="sr-only peer" checked={@checked} {@rest} />
<div class="relative w-9 h-5 bg-ui-muted peer-focus:outline-none peer-focus:ring-2 peer-focus:ring-ui-accent rounded-full peer peer-checked:after:translate-x-full rtl:peer-checked:after:-translate-x-full after:content-[''] after:absolute after:top-[2px] after:start-[2px] after:bg-ui-surface after:rounded-full after:h-4 after:w-4 after:transition-all peer-checked:bg-ui-accent ">
</div>
</label>
Expand Down
7 changes: 6 additions & 1 deletion lib/live_debugger_web/components/tree.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,12 @@ defmodule LiveDebuggerWeb.Components.Tree do
<div class="flex items-center justify-between">
<div class="shrink-0 font-medium text-secondary-text px-6 py-3"><%= @title %></div>
<%= if LiveDebugger.Feature.enabled?(:highlighting) do %>
<.toggle_switch label="Highlight" checked={@highlight?} phx-click="toggle-highlight" />
<.toggle_switch
id="highlight-switch"
label="Highlight"
checked={@highlight?}
phx-click="toggle-highlight"
/>
<% end %>
</div>
<div class="flex-1">
Expand Down