Migrate e2e tests to Playwright#947
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR migrates/extends the repo’s end-to-end coverage to Playwright by adding new Playwright specs for multiple LiveDebugger features and centralizing shared “dev app ↔ debugger” test helpers.
Changes:
- Added new Playwright e2e specs covering streams, send-event, resources, element inspection, async jobs, and dead view/dead sessions scenarios.
- Expanded
dev-dbg-test.tswith additional shared selectors/helpers used across the migrated tests. - Refactored existing global traces / associated live views tests to use the shared helper selectors.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
e2e/tests/streams.spec.ts |
Adds Playwright coverage for Streams UI and collapsible persistence (plus a standalone pre-render stream test). |
e2e/tests/send-event.spec.ts |
Adds Playwright coverage for sending events to LiveView/LiveComponent via the Send Event dialog. |
e2e/tests/resources.spec.ts |
Adds Playwright coverage for Resources tab process info + refresh rate selection. |
e2e/tests/global_traces.spec.ts |
Refactors selectors to shared helpers for Global Traces navigation/basic info checks. |
e2e/tests/elements-inspection.spec.ts |
Adds Playwright coverage for inspect mode behavior across dev app and debugger windows. |
e2e/tests/dev-dbg-test.ts |
Adds new helper exports (PID retrieval, sidebar/module info, component tree node, navbar items, collapsible localStorage setter). |
e2e/tests/dead_view_mode.spec.ts |
Adds Playwright coverage for “dead view mode” navigation + trace visibility after disconnect/crash. |
e2e/tests/dead_live_views.spec.ts |
Adds Playwright coverage for browsing/attaching to dead LiveView sessions. |
e2e/tests/async-jobs.spec.ts |
Adds Playwright coverage for Async Jobs section behavior in LiveView and LiveComponent. |
e2e/tests/associated-live-views.spec.ts |
Refactors to reuse shared helper for current node module info selector. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kraleppa
approved these changes
Mar 23, 2026
hhubert6
reviewed
Mar 23, 2026
Contributor
hhubert6
left a comment
hhubert6
left a comment
There was a problem hiding this comment.
Those files should rather use kebab-case dead_live_views.spec.ts, dead_view_mode.spec.ts, global_traces.spec.ts.
hhubert6
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.