Fix flaky e2e tests#951
Merged
Merged
Conversation
hhubert6
force-pushed
the
fix-flaky-e2e-tests
branch
from
e4cf2e7 to
8ebee80
Compare
hhubert6
force-pushed
the
fix-flaky-e2e-tests
branch
from
08c22b9 to
8d9d510
Compare
There was a problem hiding this comment.
Pull request overview
This PR aims to reduce flakiness in the Playwright e2e suite by making timing assertions more tolerant, fixing missing awaits, and adding a global warm-up step to ensure tracing is initialized before tests run.
Changes:
- Relaxed execution-time assertions in
node-inspectore2e tests to tolerate runtime variability. - Fixed async/navigation/visibility waits in serial discovery tests and stabilized assign pin/unpin interactions.
- Updated Playwright configuration to add
globalSetup, retain traces on failure, and run serial test projects with a single worker.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| e2e/tests/node-inspector.spec.ts | Makes callback timing assertions more tolerant to reduce flakes. |
| e2e/tests/discovery.serial.spec.ts | Fixes a missing await and uses a more robust “Settings” heading visibility check. |
| e2e/tests/assigns.spec.ts | Forces pin/unpin clicks to bypass actionability checks (intended stabilization). |
| e2e/playwright.config.ts | Adds global setup, keeps traces on failures, and configures serial projects for 1 worker. |
| e2e/global-setup.ts | New warm-up routine intended to ensure tracing is initialized before running tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
kraleppa
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.