Tests: Adjust shadow dom for e2e tests#967
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts the shadow DOM mode for e2e (end-to-end) tests by introducing an optional configuration flag that allows developers to run tests with an "open" shadow DOM instead of the default "closed" mode. This change enables e2e test frameworks to access elements within the shadow DOM that would otherwise be inaccessible.
Changes:
- Added
e2e?configuration option that defaults tofalse - When enabled, the shadow root is created with
mode: 'open'instead ofmode: 'closed' - Updated the meta tag generation to include an
e2e="true"attribute when the flag is enabled
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
assets/client/client.js |
Reads the e2e attribute from meta tag and uses it to determine shadow root mode (open vs closed) |
lib/live_debugger/client/config_component.ex |
Added e2e? boolean attribute and conditional meta tag generation to include e2e="true" when enabled |
lib/live_debugger.ex |
Added e2e? configuration retrieval from application config with default value of false |
priv/static/client.js |
Compiled/minified version of the client code with the same logic |
priv/static/client.js.map |
Updated source map for the compiled JavaScript |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
srzeszut
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.