Skip to content

Fix trace fullscreen highlighting #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srzeszut merged 2 commits into from
Apr 13, 2026
Merged

Fix trace fullscreen highlighting #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0f2ccce
fix scroll
srzeszut Apr 10, 2026
0e927ab
fix highlighting
srzeszut Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions assets/app/hooks/trace_body_search_highlight.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,36 @@
import { highlightSearchRanges } from '../utils/dom';
import { highlightSearchRanges, findRanges } from '../utils/dom';

import { findRanges } from '../utils/dom';
const rangesByElementId = new Map();

function updateGlobalHighlight() {
const allRanges = Array.from(rangesByElementId.values()).flat();
highlightSearchRanges('traces-search-highlight', allRanges, true);
}

const TraceBodySearchHighlight = {
mounted() {
const phrase = this.el.dataset.search_phrase;
if (phrase === undefined || phrase === '') return;

const ranges = findRanges(this.el, phrase);
highlightSearchRanges('traces-search-highlight', ranges);
this.handleHighlight();
},

updated() {
this.handleHighlight();
},

destroyed() {
rangesByElementId.delete(this.el.id);
updateGlobalHighlight();
},

handleHighlight() {
const phrase = this.el.dataset.search_phrase;
if (phrase === undefined || phrase === '') return;

const ranges = findRanges(this.el, phrase);
highlightSearchRanges('traces-search-highlight', ranges);
if (!phrase) {
rangesByElementId.delete(this.el.id);
} else {
rangesByElementId.set(this.el.id, findRanges(this.el, phrase));
}

updateGlobalHighlight();
},
};

Expand Down
2 changes: 1 addition & 1 deletion lib/live_debugger/app/debugger/callback_tracing/web/components/trace.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ defmodule LiveDebugger.App.Debugger.CallbackTracing.Web.Components.Trace do
/>
</div>
<div class={[
"max-h-[70vh] overflow-y-auto overflow-x-auto flex flex-col gap-4 items-start justify-center hover:[&>div>div>div>button]:hidden",
"max-h-[70vh] overflow-y-auto overflow-x-auto flex flex-col gap-4 items-start justify-start hover:[&>div>div>div>button]:hidden",
if(is_nil(@displayed_trace.error), do: "p-4", else: "[&>div>div>div>div>button]:hidden")
]}>
<.trace_body_navbar_wrapper
Expand Down
Loading