Fix: highlighting LiveViews by their children bounding boxes#976
Merged
Conversation
kraleppa
reviewed
Apr 20, 2026
There was a problem hiding this comment.
Pull request overview
Updates the client-side element highlighting logic so LiveViews with zero-sized root containers are highlighted using the bounding box of their visible descendants.
Changes:
- Added recursive
getHighlightRectto compute a usable highlight rectangle (falling back to children when the element’s own rect is 0x0). - Updated highlight/pulse rendering to use the computed rect rather than
offsetWidth/offsetHeight. - Regenerated bundled static artifacts (
priv/static/client.jsand source map) to reflect the new highlight behavior.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| assets/client/services/highlight.js | Implements descendant-based bounding box calculation and updates highlight/pulse sizing/positioning. |
| priv/static/client.js | Rebuilt/minified client bundle including the updated highlight logic. |
| priv/static/client.js.map | Updated source map to match the rebuilt client bundle. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kraleppa
approved these changes
Apr 21, 2026
srzeszut
approved these changes
Apr 21, 2026
hhubert6
pushed a commit
that referenced
this pull request
Apr 27, 2026
* highlight children if element has no bounding boxes * remove highlight on resize where no element found
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.